Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_avoidance_planner): use prev eb traj when failed #1192

Merged
merged 3 commits into from
Jul 7, 2022

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jun 30, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

When elastic band optimization failed, the previous elastic band optimized trajectory will be used. This mechanism is already applied to model predictive trajectory optimization.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #1192 (f027274) into main (d27e83d) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1192      +/-   ##
========================================
- Coverage   9.59%   9.56%   -0.03%     
========================================
  Files       1042    1042              
  Lines      71837   72007     +170     
  Branches   15590   15590              
========================================
  Hits        6890    6890              
- Misses     58978   59148     +170     
  Partials    5969    5969              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.57% <0.00%> (ø) Carriedforward from d27e83d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...e/obstacle_avoidance_planner/eb_path_optimizer.hpp 0.00% <ø> (ø)
...anner/include/obstacle_avoidance_planner/utils.hpp 0.00% <ø> (ø)
...stacle_avoidance_planner/src/eb_path_optimizer.cpp 0.00% <0.00%> (ø)
...g/obstacle_avoidance_planner/src/mpt_optimizer.cpp 0.00% <0.00%> (ø)
planning/obstacle_avoidance_planner/src/utils.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d27e83d...f027274. Read the comment docs.

@takayuki5168 takayuki5168 marked this pull request as ready for review July 6, 2022 23:46
@takayuki5168 takayuki5168 requested a review from tkimura4 July 6, 2022 23:47
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It is a PR to avoid using the solution of elastic band when the optimization does not converge.

It has been confirmed that PR works properly using autoware evaluator.

@takayuki5168 takayuki5168 merged commit 45d95dd into autowarefoundation:main Jul 7, 2022
@takayuki5168 takayuki5168 deleted the fix/use-prev-eb-traj branch July 7, 2022 00:03
takayuki5168 referenced this pull request in tier4/autoware.universe Sep 14, 2022
* fix(obstacle_avoidance_planner): use prev eb traj when failed

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(obstacle_avoidance_planner): modify debug message

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix conflict

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
h-ohta referenced this pull request in tier4/autoware.universe Sep 14, 2022
* fix(obstacle_avoidance_planner): use prev eb traj when failed

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(obstacle_avoidance_planner): modify debug message

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix conflict

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
h-ohta referenced this pull request in tier4/autoware.universe Sep 14, 2022
* fix(obstacle_avoidance_planner): use prev eb traj when failed

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(obstacle_avoidance_planner): modify debug message

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix conflict

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…1192)

* fix(obstacle_avoidance_planner): use prev eb traj when failed

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(obstacle_avoidance_planner): modify debug message

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix conflict

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
naokimatsunawa referenced this pull request in tier4/autoware.universe Sep 30, 2022
fix(obstacle_avoidance_planner): use prev eb traj when failed (#1192)
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…1192)

* fix(obstacle_avoidance_planner): use prev eb traj when failed

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(obstacle_avoidance_planner): modify debug message

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix conflict

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…1192)

* fix(obstacle_avoidance_planner): use prev eb traj when failed

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(obstacle_avoidance_planner): modify debug message

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix conflict

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…refoundation#1192)

* fix(obstacle_avoidance_planner): use prev eb traj when failed

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(obstacle_avoidance_planner): modify debug message

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix conflict

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…1192)

* fix(obstacle_avoidance_planner): use prev eb traj when failed

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(obstacle_avoidance_planner): modify debug message

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix conflict

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
h-ohta referenced this pull request in tier4/autoware.universe Nov 17, 2022
* fix(obstacle_avoidance_planner): use prev eb traj when failed

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(obstacle_avoidance_planner): modify debug message

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix conflict

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
h-ohta referenced this pull request in tier4/autoware.universe Nov 17, 2022
fix(obstacle_avoidance_planner): backport autowarefoundation#1881 and #1192 in awf/autoware.universe
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Apr 8, 2024
…ic-agg

feat(diagnostic_graph_aggregator): update documents and tools
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
)

Signed-off-by: Kasunori-Nakajima <kazunori.nakajima@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants