Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bluetooth_monitor): run bluetooth monitor with new parameter #1111

Conversation

ito-san
Copy link
Contributor

@ito-san ito-san commented Jun 15, 2022

Signed-off-by: ito-san fumihito.ito@tier4.jp

Description

Run bluetooth monitor with new parameters given without restarting l2ping daemon.

Related links

#1110

Tests performed

  1. Run l2ping_service and bluetooth_monitor.

    ./build/bluetooth_monitor/l2ping_service
    ros2 launch bluetooth_monitor bluetooth_monitor.launch.xml
  2. Change parameter such as rtt_warning from 0.00 to 30.00(ms).
    bluetooth_monitor.param.yaml

/**:
  ros__parameters:
    port: 7640
    timeout: 5
    rtt_warn: 30.00
    addresses: ["82:82:AB:56:32:98"]
  1. Observe RTT warning is reported.
    image

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ito-san ito-san added the type:new-feature New functionalities or additions, feature requests. label Jun 15, 2022
@ito-san ito-san requested a review from h-ohta June 15, 2022 11:16
@ito-san ito-san self-assigned this Jun 15, 2022
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #1111 (dcc0715) into main (ae75c9b) will increase coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head dcc0715 differs from pull request most recent head 704c266. Consider uploading reports for the commit 704c266 to get more accurate results

@@           Coverage Diff            @@
##            main   #1111      +/-   ##
========================================
+ Coverage   9.04%   9.08%   +0.03%     
========================================
  Files       1031    1027       -4     
  Lines      69974   69677     -297     
  Branches   14597   14506      -91     
========================================
+ Hits        6327    6328       +1     
+ Misses     58227   57936     -291     
+ Partials    5420    5413       -7     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.07% <0.00%> (+0.05%) ⬆️ Carriedforward from 98217c7

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nitor/include/bluetooth_monitor/service/l2ping.hpp 0.00% <ø> (ø)
...ude/bluetooth_monitor/service/l2ping_interface.hpp 0.00% <0.00%> (ø)
system/bluetooth_monitor/service/l2ping.cpp 0.00% <0.00%> (ø)
...ystem/bluetooth_monitor/service/l2ping_service.cpp 0.00% <0.00%> (ø)
...ene_module/occlusion_spot/occlusion_spot_utils.hpp 50.00% <0.00%> (-7.15%) ⬇️
...or_path_planner/src/behavior_path_planner_node.cpp 0.22% <0.00%> (-0.03%) ⬇️
planning/rtc_interface/src/rtc_interface.cpp 0.00% <0.00%> (ø)
...ehavior_path_planner/src/behavior_tree_manager.cpp 0.00% <0.00%> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae75c9b...704c266. Read the comment docs.

@h-ohta
Copy link
Contributor

h-ohta commented Jun 16, 2022

@ito-san Could you fix build-and-test-differential failure on humble?

@ito-san
Copy link
Contributor Author

ito-san commented Jun 17, 2022

@ito-san Could you fix build-and-test-differential failure on humble?

@h-ohta Fixed in 86080e5.

ito-san and others added 3 commits June 20, 2022 12:08
Signed-off-by: ito-san <fumihito.ito@tier4.jp>
Signed-off-by: ito-san <fumihito.ito@tier4.jp>
@h-ohta h-ohta force-pushed the feature/run_bluetooth_monitor_with_new_parameter branch from dcc0715 to 704c266 Compare June 20, 2022 03:08
@h-ohta h-ohta merged commit a4a273f into autowarefoundation:main Jun 20, 2022
@ito-san ito-san deleted the feature/run_bluetooth_monitor_with_new_parameter branch June 20, 2022 09:28
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…er4#1111)

* feat(bluetooth_monitor): run bluetooth monitor with new parameter

Signed-off-by: ito-san <fumihito.ito@tier4.jp>

* ci(pre-commit): autofix

* Fixed a build error in humble

Signed-off-by: ito-san <fumihito.ito@tier4.jp>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…er4#1111)

* feat(bluetooth_monitor): run bluetooth monitor with new parameter

Signed-off-by: ito-san <fumihito.ito@tier4.jp>

* ci(pre-commit): autofix

* Fixed a build error in humble

Signed-off-by: ito-san <fumihito.ito@tier4.jp>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…er4#1111)

* feat(bluetooth_monitor): run bluetooth monitor with new parameter

Signed-off-by: ito-san <fumihito.ito@tier4.jp>

* ci(pre-commit): autofix

* Fixed a build error in humble

Signed-off-by: ito-san <fumihito.ito@tier4.jp>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…er4#1111)

* feat(bluetooth_monitor): run bluetooth monitor with new parameter

Signed-off-by: ito-san <fumihito.ito@tier4.jp>

* ci(pre-commit): autofix

* Fixed a build error in humble

Signed-off-by: ito-san <fumihito.ito@tier4.jp>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
…oordinate and visualize it on Rviz (autowarefoundation#1111)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants