Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_avoidance_planner): empty points handling #1070

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jun 9, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

Add error handling of empty points before using findNearestIndex

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review June 9, 2022 14:00
@takayuki5168 takayuki5168 requested a review from h-ohta June 9, 2022 14:00
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #1070 (3027e39) into main (d049063) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1070      +/-   ##
========================================
- Coverage   9.04%   9.03%   -0.02%     
========================================
  Files       1013    1013              
  Lines      68783   68876      +93     
  Branches   11584   11584              
========================================
  Hits        6224    6224              
- Misses     57387   57480      +93     
  Partials    5172    5172              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.02% <0.00%> (ø) Carriedforward from d049063

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/obstacle_avoidance_planner/src/node.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d049063...3027e39. Read the comment docs.

@h-ohta h-ohta merged commit 2314965 into autowarefoundation:main Jun 9, 2022
@h-ohta h-ohta deleted the fix/obstacle-avoidance-empty-points-handling branch June 9, 2022 15:23
yn-mrse referenced this pull request in tier4/autoware.universe Jun 10, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
SoohyeokPark-MORAI pushed a commit to SoohyeokPark-MORAI/autoware.universe that referenced this pull request Jun 15, 2022
…ation#1070)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
SoohyeokPark-MORAI pushed a commit to SoohyeokPark-MORAI/autoware.universe that referenced this pull request Jun 15, 2022
…ation#1070)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
TomohitoAndo referenced this pull request in tier4/autoware.universe Jun 23, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Jul 1, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
…efoundation#1070)

* feat(duplicated_node_checker): add duplicate nodes to ignore

Signed-off-by: Dmitrii Koldaev <dmitrii.koldaev@tier4.jp>

* pre-commit

Signed-off-by: Dmitrii Koldaev <dmitrii.koldaev@tier4.jp>

---------

Signed-off-by: Dmitrii Koldaev <dmitrii.koldaev@tier4.jp>
Co-authored-by: Dmitrii Koldaev <dmitrii.koldaev@tier4.jp>
Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants