-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(simple_planning_simulator): add control_mode server #1061
feat(simple_planning_simulator): add control_mode server #1061
Conversation
263ddd5
to
feb5017
Compare
cc. @yamacir-kit |
Good
|
@yukkysaito thanks. The CI failure is due to the lack of the required messages. Need to merge the message first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
41f2d18
to
aff04ea
Compare
Codecov Report
@@ Coverage Diff @@
## main #1061 +/- ##
========================================
+ Coverage 9.59% 9.70% +0.11%
========================================
Files 1045 1045
Lines 71821 71945 +124
Branches 15590 15681 +91
========================================
+ Hits 6889 6985 +96
+ Misses 58693 58686 -7
- Partials 6239 6274 +35
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
…ndation#1061) * add control-mode in simulator Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * precommit Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update readme Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update simulator Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix typo Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
* add control-mode in simulator Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * precommit Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update readme Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update simulator Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix typo Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
* add control-mode in simulator Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * precommit Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update readme Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update simulator Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix typo Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
* add control-mode in simulator Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * precommit Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update readme Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update simulator Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix typo Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…ndation#1061) * add control-mode in simulator Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * precommit Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update readme Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update simulator Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix typo Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
* add control-mode in simulator Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * precommit Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update readme Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update simulator Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix typo Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Description
Related links
Tests performed
Run planning_simulator.launch
How to test:
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.