feat: add twist information for detected object on rviz #1014

scepter914 · 2022-06-01T01:32:25Z

Description

Add twist information for detected object on rviz.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

codecov · 2022-06-01T01:41:23Z

Codecov Report

Merging #1014 (07831cd) into main (097ec8e) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1014      +/-   ##
========================================
- Coverage   9.71%   9.71%   -0.01%     
========================================
  Files        953     953              
  Lines      64011   64022      +11     
  Branches   11181   11181              
========================================
  Hits        6217    6217              
- Misses     52631   52642      +11     
  Partials    5163    5163

Flag	Coverage Δ		*Carryforward flag
differential	`0.00% <0.00%> (?)`
total	`9.69% <0.00%> (ø)`		Carriedforward from 097ec8e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
.../src/object_detection/detected_objects_display.cpp	`0.00% <0.00%> (ø)`
...src/object_detection/predicted_objects_display.cpp	`0.00% <0.00%> (ø)`
...n/src/object_detection/tracked_objects_display.cpp	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 097ec8e...07831cd. Read the comment docs.

Signed-off-by: scepter914 <scepter914@gmail.com>

yukkysaito · 2022-06-02T04:43:40Z

common/autoware_auto_perception_rviz_plugin/src/object_detection/predicted_objects_display.cpp

+    uuid_vis_position.x = object.kinematics.initial_pose_with_covariance.pose.position.x;
+    uuid_vis_position.y = object.kinematics.initial_pose_with_covariance.pose.position.y - 0.5;


@scepter914 Can you share the image taken from view point of a third person?
I think it's good from BEV, but from view point of a third person it would be out of alignment.

It may be better to merge into one string and publish

scepter914 · 2022-07-11T09:12:30Z

Time has passed, so I will issue another PR.

…d0804 fix(avoidance): fix a bug regarding the nearest search (autowarefoundation#5575)

…#1014) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

…towarefoundation#980) * feat: use obstacle_cruise_planner and change safe_distance_margin Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: set max_vel to 40km/h Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: enable surround_obstacle_checker Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: enable surround_obstacle_checker Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: enable dynamic_avoidance and disable outside_drivable_area_stop Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: disable AEB and set the maximum velocity to 40km/h Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * enable intersection_occlusion detection Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * add parameters for obstacle_cruise_planner * add parameters for pointcloud filtering * chore(planning_launch): update motion module name (autowarefoundation#1014) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * move use_pointcloud to common parameter * disable using pointcloud by default * disable AEB diag check Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove use_pointcloud parameter * feat(diagnostic_graph_utils): launch logging node for diagnostic_graph Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * reset to autowarefoundation:main --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Co-authored-by: Mamoru Sobue <hilo.soblin@gmail.com> Co-authored-by: badai nguyen <94814556+badai-nguyen@users.noreply.github.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: Daniel Sanchez <danielsanchezaran@gmail.com> Co-authored-by: danielsanchezaran <daniel.sanchez@tier4.jp> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

…oundation#1085) * feat: use obstacle_cruise_planner and change safe_distance_margin Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: set max_vel to 40km/h Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: enable surround_obstacle_checker Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: enable surround_obstacle_checker Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: enable dynamic_avoidance and disable outside_drivable_area_stop Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: disable AEB and set the maximum velocity to 40km/h Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * enable intersection_occlusion detection Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * chore(planning_launch): update motion module name (autowarefoundation#1014) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * disable AEB diag check Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * feat(diagnostic_graph_utils): launch logging node for diagnostic_graph Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * feat(api): set launch_deprecated_api true (autowarefoundation#496) feat(api): launch_deprecated_api=true Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix(api): disable rosbridge to fix duplicated node (autowarefoundation#497) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * feat(crosswalk): more conservative when the ego pass first Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Co-authored-by: Mamoru Sobue <hilo.soblin@gmail.com> Co-authored-by: badai nguyen <94814556+badai-nguyen@users.noreply.github.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: Daniel Sanchez <danielsanchezaran@gmail.com> Co-authored-by: danielsanchezaran <daniel.sanchez@tier4.jp> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

…#1014) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

scepter914 changed the title ~~Feature/rviz detected object twist~~ feat: rviz detected object twist Jun 1, 2022

scepter914 added 2 commits June 1, 2022 16:02

fix: fix rviz object id display

a355ae0

Signed-off-by: scepter914 <scepter914@gmail.com>

feature: add twist information for detected object visualization

07831cd

Signed-off-by: scepter914 <scepter914@gmail.com>

scepter914 force-pushed the feature/rviz_detected_object_twist branch from bef6dfc to 07831cd Compare June 1, 2022 07:02

scepter914 marked this pull request as ready for review June 1, 2022 07:12

scepter914 requested review from aohsato and miursh June 1, 2022 07:12

scepter914 changed the title ~~feat: rviz detected object twist~~ feat: add twist information for detected object on rviz Jun 1, 2022

yukkysaito reviewed Jun 2, 2022

View reviewed changes

yukkysaito mentioned this pull request Jun 2, 2022

fix: fix overlap of tracked objects information on rviz #1015

Closed

7 tasks

scepter914 closed this Jul 11, 2022

scepter914 deleted the feature/rviz_detected_object_twist branch July 11, 2022 09:13

scepter914 mentioned this pull request Jul 28, 2022

feat(autoware_auto_perception_rviz_plugin): add twist information for detected object on rviz #1456

Merged

7 tasks

satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Nov 29, 2023

Merge pull request autowarefoundation#1014 from tier4/beta/v0.10.5+d4…

3457d44

…d0804 fix(avoidance): fix a bug regarding the nearest search (autowarefoundation#5575)

iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025

chore(planning_launch): update motion module name (autowarefoundation…

cf37437

…#1014) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware.universe that referenced this pull request Feb 6, 2025

chore(planning_launch): update motion module name (autowarefoundation…

d8b1c91

…#1014) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add twist information for detected object on rviz #1014

feat: add twist information for detected object on rviz #1014

scepter914 commented Jun 1, 2022 •

edited

Loading

codecov bot commented Jun 1, 2022 •

edited

Loading

yukkysaito Jun 2, 2022

yukkysaito Jun 2, 2022

scepter914 commented Jul 11, 2022

		uuid_vis_position.x = object.kinematics.initial_pose_with_covariance.pose.position.x;
		uuid_vis_position.y = object.kinematics.initial_pose_with_covariance.pose.position.y - 0.5;

feat: add twist information for detected object on rviz #1014

feat: add twist information for detected object on rviz #1014

Conversation

scepter914 commented Jun 1, 2022 • edited Loading

Description

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented Jun 1, 2022 • edited Loading

Codecov Report

yukkysaito Jun 2, 2022

Choose a reason for hiding this comment

yukkysaito Jun 2, 2022

Choose a reason for hiding this comment

scepter914 commented Jul 11, 2022

scepter914 commented Jun 1, 2022 •

edited

Loading

codecov bot commented Jun 1, 2022 •

edited

Loading