Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ground_segmentation): bring junction parameter from param file to launch argument #10102

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Feb 12, 2025

Description

set pipeline junction parameter use_single_frame_filter and use_time_series_filter, set proper input topic name for the Occupancy grid map module

Related links

autowarefoundation/autoware_launch#1327

Parent Issue:

  • Link

How was this PR tested?

tested in a local environment with logging-simulator.
option combinations of (use_single_frame_filter=false, use_time_series_filter= false), ( use_single_frame_filter=false, use_time_series_filter=true)

When use_single_frame_filter is true, elevation map is needed. However, it is too heavy in large scale maps, and could not be tested.

Notes for reviewers

None.

Interface changes

Parameter change

use_time_series_filter -> use_obstacle_segmentation_time_series_filter
use_single_frame_filter -> use_obstacle_segmentation_single_frame_filter

the parameters moved from config file in the autoware_launch

Effects on system behavior

None.

…and time series filters

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
… segmentation

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin self-assigned this Feb 12, 2025
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Feb 12, 2025
Copy link

github-actions bot commented Feb 12, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin changed the title fix(ground_segmentation): remove fix(ground_segmentation): bring junction parameter from param file to launch argument Feb 12, 2025
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 12, 2025
@technolojin technolojin marked this pull request as ready for review February 12, 2025 08:43
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for code space

…time series filters

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed new commit: fe9ba97 .

@technolojin technolojin merged commit bee8e64 into autowarefoundation:main Feb 12, 2025
28 checks passed
@technolojin technolojin deleted the fix/perception-semseg-ogm-launcher branch February 12, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants