Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autoware_trajectory): remove unnecessary tier4_planing_msgs dependency #10093

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Feb 11, 2025

Description

remove unnecessary tier4 planing msgs to port to core.

Related links

internal slack

to merge
autowarefoundation/autoware.core#138 (comment)

Parent Issue:

  • Link

How was this PR tested?

build in local
2025/02/11 https://evaluation.tier4.jp/evaluation/reports/f996e92a-0991-5cd0-90e1-8a27ce519d81/?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Feb 11, 2025
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 changed the title chore(autoware_trajectory): remove unnecessary tier4 planing msgs chore(autoware_trajectory): remove unnecessary tier4_planing_msgs Feb 11, 2025
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 11, 2025
@kosuke55 kosuke55 enabled auto-merge (squash) February 11, 2025 05:35
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.32%. Comparing base (9aa61e6) to head (7237960).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10093      +/-   ##
==========================================
- Coverage   28.32%   28.32%   -0.01%     
==========================================
  Files        1489     1491       +2     
  Lines      111272   111297      +25     
  Branches    43143    43144       +1     
==========================================
+ Hits        31519    31521       +2     
- Misses      76617    76639      +22     
- Partials     3136     3137       +1     
Flag Coverage Δ *Carryforward flag
differential 14.38% <ø> (?)
total 28.32% <ø> (ø) Carriedforward from 9aa61e6

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 changed the title chore(autoware_trajectory): remove unnecessary tier4_planing_msgs chore(autoware_trajectory): remove unnecessary tier4_planing_msgs dependency Feb 11, 2025
@kosuke55 kosuke55 merged commit a667251 into autowarefoundation:main Feb 12, 2025
51 of 52 checks passed
@kosuke55 kosuke55 deleted the chore/remove_tier4_planning_msgs branch February 12, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants