Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove dependency on autoware_universe_utils from autoware_interpolation and autoware_motion_utils #10092

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Feb 10, 2025

Description

This removes the dependency on autoware_universe_utils from autoware_interpolation and autoware_motion utils as a preparation for porting to Autoware Core.

I initially tried to only remove the dependency on only autoware_interpolation, but it seems like these two packages were tightly coupled and had to do it simultaneously.

I also had to make minor modification on autoware_path_optimizer and autoware_behavior_velocity_intersection_module which defines the overloaded function which is used by autoware_interpolation. Check acccfd2 and 737a466 for the details

Related links

Parent Issue:

This PR must be merged after
#10091

and merged before

How was this PR tested?

https://evaluation.ci.tier4.jp/evaluation/reports/d28b64f6-a94f-57c5-a6f1-7d219f129764?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…oware_utils

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
…toware_utils

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
… from autoware_universe_utils with autoware_utils

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
…nd replace getPoint with get_point

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Feb 10, 2025
Copy link

github-actions bot commented Feb 10, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 10, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 86.20690% with 16 lines in your changes missing coverage. Please review.

Project coverage is 28.25%. Comparing base (bcec02e) to head (6acf5ac).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...autoware_motion_utils/src/marker/marker_helper.cpp 71.42% 4 Missing ⚠️
...de/autoware/motion_utils/trajectory/trajectory.hpp 95.08% 1 Missing and 2 partials ⚠️
...autoware/path_optimizer/utils/trajectory_utils.hpp 57.14% 3 Missing ⚠️
...ning/autoware_path_optimizer/src/mpt_optimizer.cpp 50.00% 3 Missing ⚠️
...ware_path_optimizer/src/utils/trajectory_utils.cpp 60.00% 2 Missing ⚠️
...ing/autoware_path_optimizer/src/replan_checker.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10092      +/-   ##
==========================================
- Coverage   28.26%   28.25%   -0.01%     
==========================================
  Files        1488     1489       +1     
  Lines      111237   111531     +294     
  Branches    43156    43215      +59     
==========================================
+ Hits        31443    31518      +75     
- Misses      76776    76878     +102     
- Partials     3018     3135     +117     
Flag Coverage Δ *Carryforward flag
differential 29.02% <86.20%> (?)
total 28.26% <ø> (-0.01%) ⬇️ Carriedforward from 9aa61e6

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r mitsudome-r enabled auto-merge (squash) February 12, 2025 10:47
@mitsudome-r mitsudome-r disabled auto-merge February 12, 2025 10:47
@mitsudome-r mitsudome-r merged commit da60c4e into autowarefoundation:main Feb 12, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants