-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove dependency on autoware_universe_utils from autoware_interpolation and autoware_motion_utils #10092
feat: remove dependency on autoware_universe_utils from autoware_interpolation and autoware_motion_utils #10092
Conversation
…oware_utils Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
…toware_utils Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
… from autoware_universe_utils with autoware_utils Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
…nd replace getPoint with get_point Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10092 +/- ##
==========================================
- Coverage 28.26% 28.25% -0.01%
==========================================
Files 1488 1489 +1
Lines 111237 111531 +294
Branches 43156 43215 +59
==========================================
+ Hits 31443 31518 +75
- Misses 76776 76878 +102
- Partials 3018 3135 +117
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
This removes the dependency on autoware_universe_utils from autoware_interpolation and autoware_motion utils as a preparation for porting to Autoware Core.
I initially tried to only remove the dependency on only autoware_interpolation, but it seems like these two packages were tightly coupled and had to do it simultaneously.
I also had to make minor modification on autoware_path_optimizer and autoware_behavior_velocity_intersection_module which defines the overloaded function which is used by autoware_interpolation. Check acccfd2 and 737a466 for the details
Related links
Parent Issue:
This PR must be merged after
#10091
and merged before
How was this PR tested?
https://evaluation.ci.tier4.jp/evaluation/reports/d28b64f6-a94f-57c5-a6f1-7d219f129764?project_id=prd_jt
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.