Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(motion_velocity_planner): common implementation for motion_velocity_obstacle_<stop/slow_down/cruise>_module #10035

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jan 28, 2025

Description

Before porting the obstacle stop, slow_down, and cruise to the motion_velocity_planner, the necessary changes to the motion_velocity_planner_common and motion_velocity_planner_node are added in this PR.

Related links

#10036

How was this PR tested?

No degradation of the internal scenario tests
https://evaluation.tier4.jp/evaluation/reports/f4f8d8b1-e452-51af-998c-48b8126555e0?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 28, 2025
Copy link

github-actions bot commented Jan 28, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 28, 2025
@takayuki5168 takayuki5168 changed the title feat(motion_velocity_planner): prepare for motion_velocity_<stop/slow_down/cruise>_module feat(motion_velocity_planner): prepare for motion_velocity_obstacle_<stop/slow_down/cruise>_module Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 17.34694% with 243 lines in your changes missing coverage. Please review.

Project coverage is 29.19%. Comparing base (461dbc1) to head (c154c33).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...city_planner_common_universe/src/polygon_utils.cpp 0.00% 96 Missing ⚠️
...ocity_planner_common_universe/src/planner_data.cpp 4.54% 62 Missing and 1 partial ⚠️
...ion_velocity_planner_common_universe/src/utils.cpp 0.00% 61 Missing ⚠️
...motion_velocity_planner_node_universe/src/node.cpp 64.70% 13 Missing and 5 partials ⚠️
...e_stop_module/src/dynamic_obstacle_stop_module.cpp 66.66% 1 Missing ⚠️
...amic_obstacle_stop_module/src/object_filtering.cpp 0.00% 1 Missing ⚠️
...ut_of_lane_module/src/filter_predicted_objects.cpp 0.00% 1 Missing ⚠️
...city_out_of_lane_module/src/out_of_lane_module.cpp 87.50% 1 Missing ⚠️
...velocity_planner_common_universe/polygon_utils.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10035      +/-   ##
==========================================
- Coverage   29.21%   29.19%   -0.02%     
==========================================
  Files        1439     1448       +9     
  Lines      108115   108869     +754     
  Branches    42638    42974     +336     
==========================================
+ Hits        31588    31787     +199     
- Misses      73485    74019     +534     
- Partials     3042     3063      +21     
Flag Coverage Δ *Carryforward flag
differential 17.84% <14.33%> (?)
total 29.21% <55.55%> (ø) Carriedforward from 461dbc1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 changed the title feat(motion_velocity_planner): prepare for motion_velocity_obstacle_<stop/slow_down/cruise>_module feat(motion_velocity_planner): common implementation for motion_velocity_obstacle_<stop/slow_down/cruise>_module Jan 28, 2025
@takayuki5168 takayuki5168 removed the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 28, 2025
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 28, 2025
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jan 28, 2025
@takayuki5168 takayuki5168 marked this pull request as ready for review January 28, 2025 14:15
@takayuki5168 takayuki5168 force-pushed the feat/cruise-stop-slow-down-modules-common branch from 2381243 to 92e598e Compare January 28, 2025 14:28
Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

using autoware_perception_msgs::msg::Shape;
using autoware_planning_msgs::msg::Trajectory;
using autoware_planning_msgs::msg::TrajectoryPoint;
namespace bg = boost::geometry;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
namespace bg = boost::geometry;

@takayuki5168 takayuki5168 force-pushed the feat/cruise-stop-slow-down-modules-common branch from 92e598e to 901fbc7 Compare January 29, 2025 11:58
@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jan 29, 2025
…_down/cruise>_module

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/cruise-stop-slow-down-modules-common branch from 901fbc7 to c154c33 Compare January 29, 2025 15:29
@github-actions github-actions bot removed the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jan 29, 2025
@takayuki5168 takayuki5168 merged commit 8f461ce into autowarefoundation:main Jan 30, 2025
33 of 34 checks passed
@takayuki5168 takayuki5168 deleted the feat/cruise-stop-slow-down-modules-common branch January 30, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants