Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(goal_planner): divide extract_dynamic_object/is_goal_in_lanes util function #10019

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Jan 24, 2025

Description

move some functions as utility function

for minimizing diff for this PR #10005

Related links

Parent Issue:

  • Link

How was this PR tested?

https://evaluation.tier4.jp/evaluation/reports/aea0f58b-8b1b-5001-9025-f043b4902dd3?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…s util function

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 24, 2025
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 26, 2025
@soblin soblin enabled auto-merge (squash) January 26, 2025 23:25
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Project coverage is 29.73%. Comparing base (5872113) to head (47cface).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...are_behavior_path_goal_planner_module/src/util.cpp 0.00% 33 Missing ⚠️
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10019      +/-   ##
==========================================
- Coverage   29.74%   29.73%   -0.02%     
==========================================
  Files        1435     1438       +3     
  Lines      108308   108377      +69     
  Branches    42955    42955              
==========================================
  Hits        32221    32221              
- Misses      72958    73027      +69     
  Partials     3129     3129              
Flag Coverage Δ *Carryforward flag
differential 0.50% <0.00%> (?)
total 29.75% <ø> (+<0.01%) ⬆️ Carriedforward from 5872113

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit e8b05c2 into autowarefoundation:main Jan 26, 2025
46 of 48 checks passed
@soblin soblin deleted the refactor/goal-planner branch January 26, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants