Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some .md files have preview problems #1568

Closed
3 tasks done
mehmetdogru opened this issue Aug 10, 2022 · 10 comments
Closed
3 tasks done

Some .md files have preview problems #1568

mehmetdogru opened this issue Aug 10, 2022 · 10 comments
Labels
priority:low Lower urgency, can be addressed later. type:bug Software flaws or errors. type:documentation Creating or refining documentation. (auto-assigned)

Comments

@mehmetdogru
Copy link
Contributor

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

Usage of <figure markdown> and <figcaption> tags in some .md files like shown below causes visual problems since it is not parsed correctly.

<figure markdown>
  ![example](docs/crosswalk/example.png){width=1000}
  <figcaption>crosswalk module</figcaption>
</figure>

md_tag_issue

The files have this problems are:

Expected behavior

The pictures should be visible

Actual behavior

The pictures are not visible.

Steps to reproduce

  1. Go to any page addressed in the description e.g.
  2. Observe that there are some pictures are not visualized. (Check raw code e.g.)

Versions

No response

Possible causes

Usage of <figure markdown> and <figcaption> tags in md files

Additional context

No response

@mehmetdogru mehmetdogru added the type:bug Software flaws or errors. label Aug 10, 2022
@mehmetdogru
Copy link
Contributor Author

@xmfcx @kenji-miyake Could you take a look at this?

@kenji-miyake
Copy link
Contributor

@mehmetdogru The docs aren't for GitHub preview but MkDocs Material.
They use this feature: https://squidfunk.github.io/mkdocs-material/reference/images/#image-captions

For now, could you see https://autowarefoundation.github.io/autoware.universe/main/planning/behavior_velocity_planner/crosswalk-design/ instead?
image

However, we can consider improving the notations to support both GitHub and MkDocs Material.

@kenji-miyake
Copy link
Contributor

cc @satoshi-ota Please comment on this if you have any ideas. 🙏

@satoshi-ota
Copy link
Contributor

[background]

Previously, I tried to align center by using html tags as follows, but it is not able to shown in github.io pages because of incorrect converting of the relative image path. As far as I know, if we use html tags as follows, the absolute paths parse like /autoware.universe/planning/behavior_velocity_planner/crosswalk-design/docs/crosswalk/hoge.svg and includes unnecessary directory crosswalk-design. So, I use Mkdocs Material.

<div align="center">
  <img src="docs/crosswalk/hoge.svg">
</div>

@xmfcx
Copy link
Contributor

xmfcx commented Aug 16, 2022

Is it possible to have link in the universe .md pages to the corresponding universe documentation? Maybe created by the tool that creates documentation?

@kenji-miyake
Copy link
Contributor

kenji-miyake commented Aug 16, 2022

(Note: This comment is wrong.)

@xmfcx I think it's possible with mkdocs-macros. Just write {{ page }} and add some conversion.
https://mkdocs-macros-plugin.readthedocs.io/en/latest/macros/

image

image

@kenji-miyake
Copy link
Contributor

kenji-miyake commented Aug 16, 2022

Ah, no. We can't write it in Markdown files. lol
Sorry, please forget about it.

@kenji-miyake
Copy link
Contributor

So, I think the only way is to write the documentation URL manually, but it takes some effort.

@mitsudome-r mitsudome-r added priority:low Lower urgency, can be addressed later. type:documentation Creating or refining documentation. (auto-assigned) labels Aug 23, 2022
@BonoloAWF BonoloAWF removed this from the Bus ODD July-Aug Milestone milestone Aug 30, 2022
@mitsudome-r
Copy link
Member

@mehmetdogru Are there any issues remaining in this issue? If not, I will close this issue.

@xmfcx
Copy link
Contributor

xmfcx commented Oct 4, 2022

Using https://autowarefoundation.github.io/autoware.universe/main/ it should be ok, I will close this issue.

@xmfcx xmfcx closed this as completed Oct 4, 2022
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this issue Oct 16, 2024
…change-cancel-cant-proceed

fix(lane_change): reduce approval chattering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Lower urgency, can be addressed later. type:bug Software flaws or errors. type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

No branches or pull requests

6 participants