Skip to content

Commit

Permalink
use slash instead, fix test name
Browse files Browse the repository at this point in the history
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
  • Loading branch information
M. Fatih Cırıt committed Jun 19, 2023
1 parent 14fa392 commit 66edca2
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions simulator/autoware_auto_msgs_adapter/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ in the `autoware_auto_msgs_adapter/config` directory. Example configuration:
```yaml
/**:
ros__parameters:
msg_type_target: "autoware_auto_control_msgs::msg::AckermannControlCommand"
msg_type_target: "autoware_auto_control_msgs/msg/AckermannControlCommand"
topic_name_source: "/control/command/control_cmd"
topic_name_target: "/control/command/control_cmd_auto"
```
Expand Down Expand Up @@ -86,7 +86,7 @@ To add a new message pair,
- Create a new config file by replicating and editing:
- [adapter_control.param.yaml](config/adapter_control.param.yaml)
- Add a new test file by replicating and editing:
- [test_msg_ackerman_control_command.cpp](test/test_msg_ackerman_control_command.cpp)
- [test_msg_ackermann_control_command.cpp](test/test_msg_ackermann_control_command.cpp)
- No need to edit the `CMakeLists.txt` file as it will automatically detect the new test file.

Also make sure to test the new adapter with:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**:
ros__parameters:
msg_type_target: "autoware_auto_control_msgs::msg::AckermannControlCommand"
msg_type_target: "autoware_auto_control_msgs/msg/AckermannControlCommand"
topic_name_source: "/control/command/control_cmd"
topic_name_target: "/control/command/control_cmd_auto"
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ AutowareAutoMsgsAdapterNode::AutowareAutoMsgsAdapterNode(const rclcpp::NodeOptio
const std::string topic_name_source = declare_parameter<std::string>("topic_name_source");
const std::string topic_name_target = declare_parameter<std::string>("topic_name_target");

if (msg_type_target == "autoware_auto_control_msgs::msg::AckermannControlCommand") {
if (msg_type_target == "autoware_auto_control_msgs/msg/AckermannControlCommand") {
AdapterControl::SharedPtr adapter =
std::make_shared<AdapterControl>(*this, topic_name_source, topic_name_target);
adapter_ = std::static_pointer_cast<AdapterBaseInterface>(adapter);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ autoware_control_msgs::msg::Control generate_control_msg()

TEST(AutowareAutoMsgsAdapter, TestMsgAckermannControlCommand) // NOLINT for gtest
{
const std::string msg_type_target = "autoware_auto_control_msgs::msg::AckermannControlCommand";
const std::string msg_type_target = "autoware_auto_control_msgs/msg/AckermannControlCommand";
const std::string topic_name_source = "topic_name_source";
const std::string topic_name_target = "topic_name_target";

Expand Down

0 comments on commit 66edca2

Please sign in to comment.