-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_vehicle_info_utils): porting from universe to core #170
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
This pr depends on the new ported package "autoware_utils": autowarefoundation/autoware_utils#23 |
common/autoware_vehicle_info_utils/include/autoware_vehicle_info_utils/vehicle_info.hpp
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
- Coverage 78.75% 70.74% -8.01%
==========================================
Files 11 15 +4
Lines 193 294 +101
Branches 73 129 +56
==========================================
+ Hits 152 208 +56
- Misses 11 33 +22
- Partials 30 53 +23
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mitsudome-r -san will check and merge this PR (internal slack ) |
@JianKangEgon I know you did this to match with our coding guideline, but we would have to modify all the packages that depend on autoware_vehicle_info_utils in Autoware.Universe to fix this. For now, maybe we could make add an include file in old file path(
|
got it mits san @mitsudome-r we will revise this pr according to your comment |
Description
We are porting autoware_vehicle_info_utils to autoware.core, and this PR adds the package to core.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.