-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add apt update/upgrade to workspace install/update instructions #615
Conversation
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
35abfe9
to
b67604f
Compare
This workflow works on I will just go ahead and merge the other PR. |
9a0cc4c
to
7db8561
Compare
Documentation URL: https://autowarefoundation.github.io/autoware-documentation/pr-615/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mojomex for improving the documentation!
Fixed the deploy-docs workflow and added 2 comments to the PR.
Co-authored-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com> Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
faef811
to
6ff3cf5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
Added missing instructions to the following guides:
Specifically,
sudo apt update && sudo apt upgrade
were missing:rosdep update
androsdep install
will not upgrade previously installedros-$ROS_DISTRO-*
packages (even when Autoware is expected to be built with newer versions), which often results in unexpected Autoware build failures.From my experience in the last two weeks, following the instructions perfectly on a clean Autoware repo succeeded one out of five times mainly due to this issue.
I also added comments that for moved/removed dependencies in the
repos
files,vcstool
will not sync correctly and result in duplicate or wrongly remaining packages, in which case thesrc
directory has to be deleted and re-pulled.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.