Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: udpate the link of pointcloud_divider #609

Conversation

YamatoAndo
Copy link
Contributor

@YamatoAndo YamatoAndo commented Sep 10, 2024

Description

udpate the link of pointcloud_divider

related PR
autowarefoundation/autoware.universe#8823

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
@anhnv3991
Copy link

@YamatoAndo This looks OK to me but is there any way that I can view this PR as Autoware Documentation (like this photo)? I want to make sure that the new URL can be accessed from the web page of the documentation.
Screenshot from 2024-09-10 23-04-43

@YamatoAndo YamatoAndo added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Sep 11, 2024
Copy link

@YamatoAndo
Copy link
Contributor Author

@anhnv3991 please look ↑ URL

Copy link

@anhnv3991 anhnv3991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YamatoAndo I confirmed that the URL of autoware pointcloud divider can be accessed from the docs page. LGTM.

@YamatoAndo YamatoAndo merged commit 50e3c41 into autowarefoundation:main Sep 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants