Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add short description about imu in sensing architecture #607

Conversation

TaikiYamada4
Copy link
Contributor

@TaikiYamada4 TaikiYamada4 commented Sep 4, 2024

Description

I found that there is a lack of description about IMU messages in the sensing architecture so I added a simple one.

Related discussion: https://github.com/orgs/autowarefoundation/discussions/5064#discussioncomment-10251170

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
@TaikiYamada4 TaikiYamada4 changed the title Add short description of imu in sensing architecture chore: add short description of imu in sensing architecture Sep 4, 2024
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
@TaikiYamada4 TaikiYamada4 self-assigned this Sep 4, 2024
@TaikiYamada4 TaikiYamada4 added tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) component:sensing Data acquisition from sensors, drivers, preprocessing. labels Sep 4, 2024
@TaikiYamada4 TaikiYamada4 marked this pull request as ready for review September 4, 2024 07:14
@TaikiYamada4 TaikiYamada4 changed the title chore: add short description of imu in sensing architecture chore: add short description about imu in sensing architecture Sep 4, 2024
@TaikiYamada4 TaikiYamada4 requested review from knzo25 and drwnz September 4, 2024 07:15
@TaikiYamada4
Copy link
Contributor Author

@knzo25 @drwnz

Excuse me for interrupting.
I chose you as reviewers based on the previous PRs.

I believe this PR hurts nothing, but if there is someone who suits the role better please add them to this PR.

Copy link
Contributor

@Shin-kyoto Shin-kyoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! LGTM.

I checked this PR and I confirmed that this is good to merge.

@TaikiYamada4 TaikiYamada4 merged commit 6d70b4c into autowarefoundation:main Sep 9, 2024
15 checks passed
@TaikiYamada4 TaikiYamada4 deleted the chore/add_imu_to_sensing_architecture branch September 9, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants