Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(topic-message-handling): correct the first sample code #586

Conversation

takam5f2
Copy link
Contributor

@takam5f2 takam5f2 commented Jul 7, 2024

Description

According to the https://discourse.ros.org/t/new-documentation-on-how-to-take-a-message-from-a-subscriber-without-executing-a-callback-function/38430/5?u=takamine , a reference to the value should be given to the take method.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki AKAMINE <takayuki.akamine@tier4.jp>
@takam5f2 takam5f2 requested a review from ohsawa1204 July 7, 2024 22:24
Copy link
Contributor

@ohsawa1204 ohsawa1204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I'm sorry but I did not notice the mistake before publishing.

@takam5f2 takam5f2 merged commit 00fa0c8 into autowarefoundation:main Jul 9, 2024
13 checks passed
@takam5f2 takam5f2 deleted the fix/correct-sample-code-in-the-take-method branch July 9, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants