Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rosbag-replay-simulation): fix link for gdown #585

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Jul 5, 2024

Description

There was a mistake when I updated the link for rosbags during migration from autoware_auto_msgs to autoware_msgs in #563

Users cannot download the rosbag with gdown with the current link.
This PR will fix that issue.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Copy link

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've created same PR #591. I will remove it later.

@YoshiRi YoshiRi merged commit d44e5e2 into autowarefoundation:main Jul 25, 2024
11 checks passed
@YoshiRi YoshiRi mentioned this pull request Jul 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants