-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(design/autoware-architecture/sensing): add radar sensing document #518
Merged
scepter914
merged 18 commits into
autowarefoundation:main
from
scepter914:feat/radar_sensing
Feb 21, 2024
Merged
feat(design/autoware-architecture/sensing): add radar sensing document #518
scepter914
merged 18 commits into
autowarefoundation:main
from
scepter914:feat/radar_sensing
Feb 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
YoshiRi
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4 tasks
miursh
reviewed
Feb 19, 2024
docs/design/autoware-architecture/sensing/data-types/radar-data/radar-objects-data.md
Outdated
Show resolved
Hide resolved
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Shin-kyoto
requested changes
Feb 19, 2024
...toware-architecture/sensing/data-types/radar-data/reference-implementations/device-driver.md
Outdated
Show resolved
Hide resolved
Shin-kyoto
requested changes
Feb 19, 2024
docs/design/autoware-architecture/sensing/data-types/radar-data/radar-objects-data.md
Outdated
Show resolved
Hide resolved
docs/design/autoware-architecture/sensing/data-types/radar-data/radar-objects-data.md
Outdated
Show resolved
Hide resolved
Shin-kyoto
reviewed
Feb 19, 2024
docs/design/autoware-architecture/sensing/data-types/radar-data/radar-objects-data.md
Outdated
Show resolved
Hide resolved
docs/design/autoware-architecture/sensing/data-types/radar-data/radar-objects-data.md
Outdated
Show resolved
Hide resolved
docs/design/autoware-architecture/sensing/data-types/radar-data/radar-objects-data.md
Outdated
Show resolved
Hide resolved
...utoware-architecture/sensing/data-types/radar-data/reference-implementations/data-message.md
Outdated
Show resolved
Hide resolved
...utoware-architecture/sensing/data-types/radar-data/reference-implementations/data-message.md
Outdated
Show resolved
Hide resolved
...utoware-architecture/sensing/data-types/radar-data/reference-implementations/data-message.md
Outdated
Show resolved
Hide resolved
docs/design/autoware-architecture/sensing/data-types/radar-data/radar-pointcloud-data.md
Show resolved
Hide resolved
docs/design/autoware-architecture/sensing/data-types/radar-data/radar-pointcloud-data.md
Show resolved
Hide resolved
docs/design/autoware-architecture/sensing/data-types/radar-data/radar-pointcloud-data.md
Outdated
Show resolved
Hide resolved
docs/design/autoware-architecture/sensing/data-types/radar-data/radar-pointcloud-data.md
Outdated
Show resolved
Hide resolved
…a/reference-implementations/device-driver.md Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com> Signed-off-by: scepter914 <scepter914@gmail.com>
…a/radar-objects-data.md Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com> Signed-off-by: scepter914 <scepter914@gmail.com>
…a/radar-objects-data.md Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com> Signed-off-by: scepter914 <scepter914@gmail.com>
…a/radar-objects-data.md Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com> Signed-off-by: scepter914 <scepter914@gmail.com>
…a/radar-objects-data.md Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com> Signed-off-by: scepter914 <scepter914@gmail.com>
…a/reference-implementations/data-message.md Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com> Signed-off-by: scepter914 <scepter914@gmail.com>
…a/reference-implementations/data-message.md Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com> Signed-off-by: scepter914 <scepter914@gmail.com>
…a/radar-pointcloud-data.md Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com> Signed-off-by: scepter914 <scepter914@gmail.com>
…a/radar-pointcloud-data.md Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com> Signed-off-by: scepter914 <scepter914@gmail.com>
…a/radar-objects-data.md Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com> Signed-off-by: scepter914 <scepter914@gmail.com>
295f105
to
99cd70c
Compare
Signed-off-by: scepter914 <scepter914@gmail.com>
miursh
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Shin-kyoto
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add radar sensing document.
The contents of the documents are as below.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.