Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: !!! info notation correction #512

Merged
merged 6 commits into from
Jan 29, 2024
Merged

fix: !!! info notation correction #512

merged 6 commits into from
Jan 29, 2024

Conversation

KhalilSelyan
Copy link
Contributor

@KhalilSelyan KhalilSelyan commented Jan 29, 2024

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@KhalilSelyan KhalilSelyan requested a review from xmfcx January 29, 2024 14:54
@KhalilSelyan KhalilSelyan self-assigned this Jan 29, 2024
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
@KhalilSelyan KhalilSelyan force-pushed the fix/docs-gui-integration branch from 1d7dc81 to f7ec755 Compare January 29, 2024 14:57
KhalilSelyan and others added 2 commits January 29, 2024 18:03
Co-authored-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com>
Co-authored-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
@KhalilSelyan KhalilSelyan force-pushed the fix/docs-gui-integration branch from fb22b42 to 01bce8f Compare January 29, 2024 15:06
@xmfcx xmfcx added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Jan 29, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Jan 29, 2024

Screenshot from 2024-01-29 18-22-33
it works! lets apply to all. Also I think I added an additional whitespace on L70, you can undo that

Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
@KhalilSelyan KhalilSelyan force-pushed the fix/docs-gui-integration branch from 468ca4c to 90efb6a Compare January 29, 2024 15:25
Co-authored-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com>
@KhalilSelyan KhalilSelyan force-pushed the fix/docs-gui-integration branch from de7e732 to dbd16d9 Compare January 29, 2024 15:48
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx force-pushed the fix/docs-gui-integration branch from dbd16d9 to 929c4d6 Compare January 29, 2024 15:50
@xmfcx xmfcx merged commit 2989c8c into main Jan 29, 2024
9 checks passed
@xmfcx xmfcx deleted the fix/docs-gui-integration branch January 29, 2024 15:53
Ericpotato pushed a commit to Ericpotato/autoware-documentation that referenced this pull request Feb 1, 2024
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: Ericpotato <zhanhong.yan@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants