Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tutorials): add pull-over and pull-out scenario in tutorials page #510

Merged

Conversation

Ericpotato
Copy link
Contributor

Description

add pull-over and pull-out scenario in tutorials page

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@shmpwk shmpwk self-requested a review January 18, 2024 05:58
@shmpwk shmpwk added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Jan 18, 2024
@shmpwk
Copy link
Contributor

shmpwk commented Jan 18, 2024

Please click Set DCO to pass
image

@shmpwk
Copy link
Contributor

shmpwk commented Jan 18, 2024

FYI, we usually call road shoulder. https://autowarefoundation.github.io/autoware.universe/main/planning/behavior_path_goal_planner_module/

Ericpotato and others added 5 commits January 18, 2024 16:14
Signed-off-by: Ericpotatoy <zhanhong.yan@tier4.jp>
Signed-off-by: Ericpotatoy <zhanhong.yan@tier4.jp>
Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Signed-off-by: Ericpotatoy <zhanhong.yan@tier4.jp>
Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Signed-off-by: Ericpotatoy <zhanhong.yan@tier4.jp>
Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Signed-off-by: Ericpotatoy <zhanhong.yan@tier4.jp>
@Ericpotato Ericpotato force-pushed the add-pullover-pullout-tutorial branch from 9d4782a to ab503be Compare January 18, 2024 07:20
@Ericpotato
Copy link
Contributor Author

FYI, we usually call road shoulder. https://autowarefoundation.github.io/autoware.universe/main/planning/behavior_path_goal_planner_module/

Thank you ! I've resolved DCO errors, it should be working now.
ಥ‿ಥ
It's not easy, but I think I am getting used to Github slowly

@shmpwk
Copy link
Contributor

shmpwk commented Jan 18, 2024

@Ericpotato
A minor request. Could you please make the picture more horizontal rectangle? It would be more beautiful.

shmpwk and others added 6 commits January 18, 2024 19:31
Signed-off-by: Ericpotatoy <zhanhong.yan@tier4.jp>
Signed-off-by: Ericpotatoy <zhanhong.yan@tier4.jp>
Signed-off-by: Ericpotatoy <zhanhong.yan@tier4.jp>
Signed-off-by: Ericpotatoy <zhanhong.yan@tier4.jp>
Signed-off-by: Ericpotatoy <zhanhong.yan@tier4.jp>
Signed-off-by: Ericpotatoy <zhanhong.yan@tier4.jp>
@Ericpotato Ericpotato force-pushed the add-pullover-pullout-tutorial branch from 6fcdc6d to 9096d54 Compare January 18, 2024 10:32
@Ericpotato
Copy link
Contributor Author

A minor request. Could you please make the picture more horizontal rectangle? It would be more beautiful.

Done! Please check

@shmpwk
Copy link
Contributor

shmpwk commented Jan 18, 2024

@Ericpotato Could you check the file name correspondence?

Signed-off-by: Ericpotatoy <zhanhong.yan@tier4.jp>
@shmpwk
Copy link
Contributor

shmpwk commented Jan 19, 2024

@Ericpotato
Sorry I could not to explain clearly but what "more horizontal rectangle" means is to make width all the same.
Currently, it looks the widths are not aligned.
image

Signed-off-by: Ericpotatoy <zhanhong.yan@tier4.jp>
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk merged commit ec6d5b9 into autowarefoundation:main Jan 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants