Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integrating autoware): fix the wrong name in creating sensor model #505

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@
3. `<YOUR-VEHICLE-NAME>_sensor_kit_launch`

Previously,
we forked our vehicle model at the [creating autoware repositories](../../creating-your-autoware-repositories/creating-autoware-repositories.md) page step.
we forked our sensor model at the [creating autoware repositories](../../creating-your-autoware-repositories/creating-autoware-repositories.md) page step.
For instance,
we created [tutorial_vehicle_launch](https://github.com/leo-drive/tutorial_vehicle_launch)
we created [tutorial_vehicle_sensor_kit_launch](https://github.com/leo-drive/tutorial_vehicle_sensor_kit_launch)
as an implementation example for the said step.
Please ensure that the <YOUR-VEHICLE-NAME>\_vehicle_launch repository is included in Autoware,
Please ensure that the <YOUR-VEHICLE-NAME>\_sensor_kit_launch repository is included in Autoware,
following the directory structure below:

```diff
Expand All @@ -26,9 +26,9 @@
└─ <YOUR-VEHICLE-NAME>_sensor_kit_launch/
```

If your forked Autoware meta-repository doesn't include `<YOUR-VEHICLE-NAME>_vehicle_launch` with the correct folder structure
If your forked Autoware meta-repository doesn't include `<YOUR-VEHICLE-NAME>_sensor_kit_launch` with the correct folder structure
as shown above,
please add your forked `<YOUR-VEHICLE-NAME>_vehicle_launch` repository to the autoware.repos file
please add your forked `<YOUR-VEHICLE-NAME>_sensor_kit_launch` repository to the autoware.repos file
and run the vcs import src < autoware.repos command in your terminal
to import the newly included repositories at autoware.repos file.

Expand Down Expand Up @@ -75,7 +75,7 @@
```

Remember to apply the name changes and project method for **BOTH**
`<YOUR-VEHICLE-NAME>_vehicle_description`and `<YOUR-VEHICLE-NAME>_vehicle_launch` ROS 2 packages.
`<YOUR-VEHICLE-NAME>_sensor_kit_description`and `<YOUR-VEHICLE-NAME>_sensor_kit_launch` ROS 2 packages.
Once finished, we can proceed to build said packages:

```bash
Expand Down Expand Up @@ -155,7 +155,7 @@
roll: 0.0
pitch: 0.0
yaw: 0.0
rs_bpearl_front_base_link: # Lidar

Check warning on line 158 in docs/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/creating-sensor-model/index.md

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (bpearl)
x: 0.0
y: 0.0
z: 0.0
Expand Down Expand Up @@ -196,12 +196,12 @@

### sensor_kit.xacro

We will add our sensors and remove unnecessary xacros from this file.

Check warning on line 199 in docs/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/creating-sensor-model/index.md

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (xacros)
For example,
we want
to add our lidar sensor with `velodyne_top` frame from the sensor driver,
we will add the following xacro to our sensor_kit.xacro file.
Please add your sensors to this file and remove unnecessary sensor's xacros.

Check warning on line 204 in docs/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/creating-sensor-model/index.md

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (xacros)

```xml
<!-- lidar -->
Expand Down Expand Up @@ -258,7 +258,7 @@
${calibration['sensor_kit_base_link']['rs_helios_top_base_link']['yaw']}"
/>
</xacro:VLS-128>
<xacro:VLP-16 parent="sensor_kit_base_link" name="rs_bpearl_front" topic="/points_raw" hz="10" samples="220" gpu="$(arg gpu)">

Check warning on line 261 in docs/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/creating-sensor-model/index.md

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (bpearl)
<origin
xyz="${calibration['sensor_kit_base_link']['rs_bpearl_front_base_link']['x']}
${calibration['sensor_kit_base_link']['rs_bpearl_front_base_link']['y']}
Expand Down Expand Up @@ -346,7 +346,7 @@
</robot>
```

At out tutorial vehicle,
At our tutorial vehicle,
there is no directly sensor transformation for base_link,
thus our sensors.xacro file includes only `base_link` and `sensor_kit_base_link` link.

Expand Down Expand Up @@ -564,7 +564,7 @@

Then, you can launch tensorrt_yolo node via adding yolo.launch.xml on your design like that:
(i.e.,
it is included in [tier4_perception_launch](https://github.com/autowarefoundation/autoware.universe/blob/ad69c2851b7b84e12c9f0c3b177fb6a9032bf284/launch/tier4_perception_launch/launch/object_recognition/detection/camera_lidar_fusion_based_detection.launch.xml#L49-L59) package in autwoare.universe)

Check warning on line 567 in docs/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/creating-sensor-model/index.md

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (autwoare)
`image_number` argument defines your camera number

```xml
Expand Down Expand Up @@ -609,7 +609,7 @@
from launch.actions import OpaqueFunction
import yaml

def launch_setup(context, *args, **kwargs):

Check warning on line 612 in docs/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/creating-sensor-model/index.md

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (kwargs)

output_topic= LaunchConfiguration("output_topic").perform(context)

Expand Down Expand Up @@ -709,7 +709,7 @@
launch_arguments = []

def add_launch_arg(name: str, default_value=None, description=None):
# a default_value of None is equivalent to not passing that kwarg at all

Check warning on line 712 in docs/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/creating-sensor-model/index.md

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (kwarg)
launch_arguments.append(
DeclareLaunchArgument(name, default_value=default_value, description=description)
)
Expand Down
Loading