Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pull-request-guidelines): add note of updating pull request branch #501

Merged
merged 2 commits into from
Dec 14, 2023
Merged

docs(pull-request-guidelines): add note of updating pull request branch #501

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1b9a53
docs(pull-request-guidelines): add notes of updating pull request branch
isamu-takagi Dec 13, 2023
dfbe0b9
Update docs/contributing/pull-request-guidelines/index.md
shmpwk Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/contributing/pull-request-guidelines/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ Use this workflow as a reference when you contribute to Autoware.
- If you don't agree with a review comment, ask the reviewers for a rational reason.
- The reviewers are obligated to make the author understand the meanings of each comment.
- After you have done with the review comments, re-request a review to the reviewers and back to 6.
- Avoid using force push as much as possible so reviewers only see the differences. More precisely, at least keep a commit history up to the point of review because GitHub Web UI such as the suggested change may require rebase to pass DCO CI.
- If there are no more new review comments, the reviewers will approve the pull request and proceed to 8.
8. Merge the pull request.
- Anyone with write access can merge the pull request if there is no special request from maintainers.
Expand Down
Loading