Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit documentation platform for better UI #4

Closed
Tracked by #1
kenji-miyake opened this issue Dec 21, 2021 · 16 comments
Closed
Tracked by #1

Revisit documentation platform for better UI #4

kenji-miyake opened this issue Dec 21, 2021 · 16 comments

Comments

@kenji-miyake
Copy link
Contributor

kenji-miyake commented Dec 21, 2021

Now Autoware.Auto uses Doxygen, but it has some disadvantages:

  • UI is not modern.
  • Search is slow.
  • Some special syntaxes that developers aren't used to are required.
  • etc.

Therefore, we'll propose a new documentation platform to use mkdocs-material
The advantages are:

  • UI is beautiful.
  • Search experience is great.
  • Pure Markdown can be used.
  • Multiple versions of the documentation are supported.
  • etc.

Actually, we've already introduced this in autoware.universe as a trial.

@kenji-miyake
Copy link
Contributor Author

We'll set up mkdocs-material for this repository as well and try to prepare the equivalent documents as Autoware.Auto.

@xmfcx
Copy link
Contributor

xmfcx commented Dec 22, 2021

Why not https://readthedocs.org/ ? (I've never heard of mkdocs before)

(ROS2 uses it and it is also fast and beautiful https://docs.ros.org/en/rolling/index.html )

@kenji-miyake
Copy link
Contributor Author

kenji-miyake commented Dec 22, 2021

@xmfcx Thank you for your comment! 😄

Why not https://readthedocs.org/ ?

Yes, Read the Docs can be a candidate.

IMO,

(I've never heard of mkdocs before)

It's very widely used!

@mitsudome-r
Copy link
Member

Some of the features that we want:

  • We want have searching result to be shown in the separate page like in read the docs
  • We should have versioning of documents

@kenji-miyake
Copy link
Contributor Author

We want have searching result to be shown in the separate page like in read the docs

This is available by this option if we use readthedocs theme.
https://www.mkdocs.org/dev-guide/themes/#include_search_page

image

However, material theme seems not supporting this.
https://github.com/squidfunk/mkdocs-material/blob/727f94f8676fea43a182703a558f08a19b6ceccb/mkdocs.yml#L47

@xmfcx Is this feature mandatory? If we'd like to simply share the URL, it's supported by material theme.
https://squidfunk.github.io/mkdocs-material/setup/setting-up-site-search/?q=test
image

We should have versioning of documents

This is available now by mike.

@xmfcx
Copy link
Contributor

xmfcx commented Jan 10, 2022

I like readthedocs theme more actually. The material theme feels more modern but incomplete, spaced out.

@kenji-miyake
Copy link
Contributor Author

@xmfcx Thank you, I see. But I love the material theme.
So, since it depends on the person, I think it's better to decide by a questionnaire or something. Is that okay for you?

If it's okay, I'll send a PR for the comparison after I add some content.

Also, there is one more thing I'd like to clarify.
Is it okay for you to use MkDocs? I mean, are you concerned only about the theme?
Or do you want to use other tools such as Sphinx, mdBook, etc?

@xmfcx
Copy link
Contributor

xmfcx commented Jan 12, 2022

@xmfcx Thank you, I see. But I love the material theme. So, since it depends on the person, I think it's better to decide by a questionnaire or something. Is that okay for you?

If you want, you can arrange one in the slack. To me https://docs.ros.org/en/rolling/index.html looks like the perfect documentation style for me. It is structured and solid. https://iceoryx.io/v1.0.1/getting-started/what-is-iceoryx/ on the other hand looks so spaced out, empty and incomplete.

If it's okay, I'll send a PR for the comparison after I add some content.

I don't think that's necessary, we know how both look like.

Also, there is one more thing I'd like to clarify. Is it okay for you to use MkDocs? I mean, are you concerned only about the theme? Or do you want to use other tools such as Sphinx, mdBook, etc?

https://docs.readthedocs.io/en/stable/intro/getting-started-with-sphinx.html#using-markdown-with-sphinx this I think is our best bet since it has the markdown that we want to use and core readthedocs that I like.

@kenji-miyake
Copy link
Contributor Author

on the other hand looks so spaced out, empty and incomplete.

Could you show the points you have concerns, in a picture like this?
Are the red rectangle areas what you concerned?

image

I don't think that's necessary, we know how both look like.

Yes, but I guess we need to compare not only the looking but also some features.
Material theme has many customizable features.

features:
- navigation.expand
- navigation.indexes
- navigation.instant
- navigation.sections
- navigation.tabs
- navigation.tabs.sticky
- navigation.top
favicon: assets/images/autoware-foundation.png
icon:
logo: fontawesome/solid/car
repo: fontawesome/brands/github
language: en
palette:
- scheme: default
primary: white
toggle:
icon: material/weather-sunny
name: Switch to dark mode
- scheme: slate
primary: grey
toggle:
icon: material/weather-night
name: Switch to light mode

You can test the features here.
https://squidfunk.github.io/mkdocs-material/setup/setting-up-navigation/

https://docs.readthedocs.io/en/stable/intro/getting-started-with-sphinx.html#using-markdown-with-sphinx this I think is our best bet since it has the markdown that we want to use and core readthedocs that I like.

As mentioned here, my concern is whether we can use the full features, I'm not sure about that and it takes some time to learn that.


Anyway, as a result of https://gitlab.com/autowarefoundation/autoware-foundation/-/issues/198, we agreed to start with MkDocs and consider moving to Read the Docs later.

@alexandrx
Copy link

alexandrx commented Jan 12, 2022

@kenji-miyake Regarding arguments in favour of mkdocs-materials or other, you could help us listing up some key open source projects using it. In particular, if ROS community also use it as main documentation platform, or there is a trend to, then there will not be many objections.

Similar to Doxygen, it seems capable of rendering LaTeX, so documentation involving some mathematical terms, diagrams, etc., should be possible.

@xmfcx
Copy link
Contributor

xmfcx commented Jan 12, 2022

@kenji-miyake Regarding arguments in favour of mkdocs-materials or other, you could help us listing up some key open source projects using it. In particular, if ROS community also use it as main documentation platform, or there is a trend to, then there will not be many objections.

He mentioned them in this comment above: #4 (comment)

@xmfcx
Copy link
Contributor

xmfcx commented Jan 12, 2022

@kenji-miyake

on the other hand looks so spaced out, empty and incomplete.

Could you show the points you have concerns, in a picture like this? Are the red rectangle areas what you concerned?

Screenshot from 2022-01-12 19-42-33

@kenji-miyake kenji-miyake changed the title Revisit documentation platform for the better UI Revisit documentation platform for better UI Jan 18, 2022
kenji-miyake added a commit to KeisukeShima/autoware-documentation that referenced this issue Mar 8, 2022
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@stale
Copy link

stale bot commented Mar 24, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Mar 24, 2022
@kenji-miyake
Copy link
Contributor Author

@xmfcx Do you think we can close this and create a new issue if necessary in the future?

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Mar 24, 2022
@kenji-miyake
Copy link
Contributor Author

I assume yes.
#4 (comment)

@kenji-miyake
Copy link
Contributor Author

Another user of MkDocs Material.
https://github.com/pi-hole/pi-hole
https://docs.pi-hole.net/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants