Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update feature added in AWSIM-Labs #90

Closed

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Jun 5, 2024

Description

The current table makes it look like AWSIM is worse than AWSIM-Labs with a lot of X, but I don't think it is fair to make such comparisons if you are making modification on top of fork.

I would like to modify the documentation to make sure that we're not being disrespectful to upstream developers.

Related links

N/A

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link

github-actions bot commented Jun 5, 2024

@mitsudome-r mitsudome-r requested a review from xmfcx June 5, 2024 16:22
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
@mitsudome-r
Copy link
Member Author

NOTE from the discussion with Fatih:
We are planning to move this table to Autoware Documentation. There we will have both AWSIM-Labs and TIER IV's AWSIM team to update the table to show the difference between the two.

We can merge this PR once we create the table in Autoware Documentation.

docs/index.md Show resolved Hide resolved
@xmfcx
Copy link

xmfcx commented Jun 16, 2024

You also need to update the README.md section with the new text:

See [Feature differences from the TIER IV/AWSIM in the Autoware Documentation](https://autowarefoundation.github.io/autoware-documentation/main/tutorials/ad-hoc-simulation/digital-twin-simulation/awsim-tutorial/#feature-differences-from-the-awsim-and-awsim-labs).

@xmfcx
Copy link

xmfcx commented Jul 2, 2024

@mozhoku could you take over this task?

docs/index.md Show resolved Hide resolved
@xmfcx
Copy link

xmfcx commented Jul 2, 2024

@xmfcx xmfcx closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants