Skip to content
This repository has been archived by the owner on Dec 16, 2020. It is now read-only.

chore(circleci): ignore audit exit code #3

Merged
merged 3 commits into from
Jun 24, 2019
Merged

chore(circleci): ignore audit exit code #3

merged 3 commits into from
Jun 24, 2019

Conversation

trs
Copy link
Contributor

@trs trs commented Jun 24, 2019

Ironically, these vulnerabilities come down to the npm package not
updating their dependencies with these fixes.

Temporarily ignore npm audit exit code, in order to release new
versions until npm figures things out.

nodejs/node-gyp#1717
sass/node-sass#2625

trs added 3 commits June 24, 2019 09:57
Ironically, these vulnerabilities come down to the `npm` package not
updating their dependencies with these fixes.

Temporarily ignore `npm audit` exit code, in order to release new
versions until npm figures things out.

nodejs/node-gyp#1717
sass/node-sass#2625
chore(circleci): ignore audit exit code
@trs trs requested a review from a team June 24, 2019 16:08
@trs trs self-assigned this Jun 24, 2019
@trs trs added the chore label Jun 24, 2019
Copy link
Contributor

@matt-forster matt-forster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell from those threads the issues should be resolved?

@trs
Copy link
Contributor Author

trs commented Jun 24, 2019

It would be, but the issue is they are dependents of npm-lifecycle and npm. Which are still using the vulnerable versions.

@trs trs merged commit 240dae0 into autovance:master Jun 24, 2019
@botovance
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants