970 enable rc controller in webui #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#973 Now controllers take mode and recording as inputs and use those as defaults. The idea is that if one of the controllers get's user input that changes that state, then it get's propagated to the next controller via these defaults.
- web.py will send websocket message with changes to the client - client will iterate through the changes and update fields in state - If state actually changed then client we redraw the UI
- The python code uses 3 modes; 'local', 'user', 'local_angle' - The web code has the same functional modes, but calls them 'auto', 'user', 'auto_angle'. - So when the server sends a mode change to the javascript client it does not sync correctly because of the name differences. This commit makes them match.
- the mode change in the controller was getting overridden by the pass-through default - now we latch the change in the controller and if the latch has a value in run_threaded, then we use that rather than the pass-through default. - this change fixes the process that changes the webui when the user changes the mode with a controller button.
…m/autorope/donkeycar into 970-enable-RC-controller-in-webui
- added code to latch changes in the background thread and then commit them in run_threaded(). - added code to send only changed state from web to server, so we are not overwriting unchanged state. - now the drive mode can be changes with either the web ui or the game controller and it will be correctly syncronized and reflected in the webui. - added help for user mode shortcut keys in web controller.
…m/autorope/donkeycar into 970-enable-RC-controller-in-webui
DocGarbanzo
reviewed
Jan 23, 2022
| logger.debug(f"Updating web client: {data_str}") | ||
| wsclient.write_message(data_str) | ||
| except Exception as e: | ||
| print(e) |
There was a problem hiding this comment.
This should be a logger error.
DocGarbanzo
approved these changes
Feb 1, 2022
This was referenced Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #973 and Issue #972
For issue #973:
For Issue #972:
User,Full AutoandAuto Steering. I chose not to use the suggest ofAuto Steering and Manual Throttlebecause it was too long for the ui.In addition I added an explanation of the keyboard shortcuts for change the drive mode and recording in the web ui to the model help popup.