-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing import for UI and added windows support where tensorrt is not available #975
Conversation
… conversion function so the interpreter import doesn't fail on windows where trt is not fully supported.
Doing Windows conda install using the branch, after successfully recreating the donkey conda environment and activating, my system does not find
That all succeeded, then:
|
Attempting to install the version of tensorflow-gpu specified in the install instructions failes
Attempting installation The fix here to install with pip |
@Ezward - thanks for the thorough testing, that's quite useful to understand potential issues for windows users:
|
…hich we are hitting in this PR, too: https://github.com/github/super-linter/issues/2253
…ining' into fix_windows_support_for_training
I've bumped the superlinter to version 4 as well, because we are hitting the bug described here: https://github.com/github/super-linter/issues/2253 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this. I think windows users will appreciate it. I'm a linux user, but I found it much easier to actually get the gpu working in windows than I did in linux.
Fix missing imports and supporting of windows where tensorrt is potentially not working
Bumped the superlinter to v4 because of issue: https://github.com/github/super-linter/issues/2253
Also, moved tensorrt imports into function, so loading will not fail unless a tensorrt conversion is called. It seems windows 11 doesn't support tensorrt yet.
Bumped version bugfix digit