add a __main__ self-test configured with a json file #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DocGarbanzo
approved these changes
Jun 26, 2023
|
|
||
|
|
||
|
|
||
| def imgTransformListFromJson(transforms_config): |
There was a problem hiding this comment.
Small comment. Camelcase should preferably be replaced by underscore concatenation for python functions.
|
|
||
|
|
||
|
|
||
| def loadImgTransformJson(filepath): |
- the __main__ self-test can load an image from a file or use the video stream from a camera - It takes the path to a json file that specifies a list of image transforms, there order and their arguments - functions have been added to load and parse the json file and use it to construct the transform pipeline. - The transform pipeline is implemented with a run() method that applies the transforms in order. - Comments in the code document the json file format.
810f92f to
5d2a841
Compare
- no other functional changes, just renaming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged after PR #1133
add a
__main__self-test configured with a json fileI created this because I found bugs in the image transformations when I tried to create a chain of them. I needed a test where I could try many combinations easily, so I created a function to create a image transform pipeline from a json file and created the
__main__to use it.You provide a json file that specifies a transformation pipeline and configures either an single image to be loaded or a camera to be used. The image transformation pipeline is constructed and applied the configured image source and shown in an opencv window.
This json specifies a pipeline that applies canny edge detection to the image.
Here the "BLUR" and "CANNY" transforms are using default parameters, so the argument object is empty. The "CROP" transform is supplied with a argument object that specifies all named parameters and their values. The color conversion transforms "RGB2GRAY" and "GRAY2RGB" do not have arguments so no argument object is supplied.
If it was in a json file named
canny_pipeline.jsoninpihome folder the usage would be: