Fix calibrate script #1034
Merged
Fix calibrate script #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ezward
reviewed
Aug 14, 2022
| @@ -113,22 +115,14 @@ def drive(cfg ): | |||
| drive_train = RoboHATDriver(cfg) | |||
| V.add(drive_train, inputs=['angle', 'throttle']) | |||
|
|
|||
|
|
|||
| # TODO: monkeypatching is bad!!! | |||
There was a problem hiding this comment.
I think those values are not even used anywhere in the controller or here in the calibration template. Maybe some other code uses them; you right - this is very hacky.
Ezward
approved these changes
Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
calibrate.pyscript that is copied into the car directory and connects to the web server's calibration page. The script was still using the old specification of PWM pins, but the complete template has been upgraded to the new definitions already. This PR addresses that inconsistency. We also remove some unfortunate code form the script. There is still a bad issue w/ monkeypatching going on.