Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare mainnet chainspec #3205

Merged
merged 2 commits into from
Nov 4, 2024
Merged

prepare mainnet chainspec #3205

merged 2 commits into from
Nov 4, 2024

Conversation

dariolina
Copy link
Member

I have modified taurus-compiled to mainnet-compiled to build the spec, removed genesis domains and included the bootstrap nodes we prepared on infra side.
Effectively, by including the JSON we now carry 2 copies of genesis allocations information, which is not ideal. I would like to keep it as is for the next days, however.

Code contributor checklist:

Copy link
Member

@NingLin-P NingLin-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense.

One nit about the chain-spec-raw-mainnit.json file, I wonder if we should build this file publicly in CI for transparency to the community. Although I have locally compiled the binary from this branch and built the chain spec which is exactly the same as the chain spec this PR brought except for one key 0x3a636f6465 in the genesis state, which is probably the runtime code.

@dariolina
Copy link
Member Author

How would I specify non-default bootstrap nodes to build it CI?

@NingLin-P
Copy link
Member

How would I specify non-default bootstrap nodes to build it CI?

We will need 2 PRs, the first PR modifies taurus-compiled to mainnet-compiled, we build the chain spec in CI, and then the second PR brings the resulting chain spec file and adds the bootstrap node to it.

@dariolina
Copy link
Member Author

Ok. I can do that!

@NingLin-P
Copy link
Member

BTW, we probably also need to change taurus-compiled to mainnet-compiled in the CI workload in the first PR:

docker run --rm -u root ${{ steps.build.outputs.digest }} build-spec --chain taurus-compiled --disable-default-bootnode > chain-spec-taurus.json
docker run --rm -u root ${{ steps.build.outputs.digest }} build-spec --chain taurus-compiled --disable-default-bootnode --raw > chain-spec-raw-taurus.json

@dariolina
Copy link
Member Author

I was going to do that after this one separately.
I can modify this one to rename in CI and the function (without JSON) and make a separate one for json

@dariolina dariolina added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 1d864f5 Nov 4, 2024
8 checks passed
@dariolina dariolina deleted the mainnet-chainspec branch November 4, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants