Overhaul the extraction of bundles and receipts #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No logical changes.
- Make `verify_vrf_proof` a method of ProofOfElection.
- Remove resolved TODO in {core,system}_gossip_message_validator.
- Rename `extract_stored_bundles_at` to `successfully_submitted_bundles_at`
acf5539 to
ceab1f8
Compare
liuchengxu
commented
May 15, 2023
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
NingLin-P
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily ensures the extracted bundles/receipts/fraud proofs from the original primary block are finally accepted by the primary chain, i.e., the
submit_bundle/submit_fraud_proofcalls are successful in the end. Temporary runtime storage will be cleared on block initialize is used to store the hashes of successful bundles and fraud proofs. Runtime APIextract_stored_bundle_hashesis also changed to make use of this storage (This is mainly for consistency favor as I was reluctant to spend time thinking about the fraud proof events at present).Close #1446
Code contributor checklist: