Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Substrate fork #1053

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Upgrade Substrate fork #1053

merged 1 commit into from
Jan 6, 2023

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented Jan 6, 2023

Upstream Substrate merged into our fork cleanly, so it is still on subspace-v3 branch.

The biggest source of changes here is further upstream refactoring replacing BlockId with Block::Hash in various places.

Another source of changes is tracing_unbounded that has second argument pointing to number of messages in flight after which warning will be printed. In most cases we expect just one message there, but due to upstream design decisions to no guarantee memory ordering there and use i64 we can't really put a specific number on it deterministically, so I put 100 everywhere, please correct it if there is a place where we do expect those messages to be buffered and higher threshold is desired. See paritytech/substrate#12971 for details.

Some notable upstream changes we'll likely want to leverage going forward:

There are some fixes, including to canonicalization you're already aware of.

Code contributor checklist:

@nazar-pc nazar-pc merged commit aada560 into main Jan 6, 2023
@nazar-pc nazar-pc deleted the upgrade-substrate branch January 6, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants