Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

fix most of the clippy errors #914

fix most of the clippy errors

fix most of the clippy errors #914

Triggered via push October 30, 2023 18:26
Status Failure
Total duration 2h 36m 34s
Artifacts

push.yml

on: push
Matrix: clippy
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

14 errors and 4 warnings
fmt
The process '/home/ubuntu/.cargo/bin/cargo' failed with exit code 1
very complex type used. Consider factoring parts into `type` definitions: farmer/src/lib.rs#L683
error: very complex type used. Consider factoring parts into `type` definitions --> farmer/src/lib.rs:683:9 | 683 | Option<mpsc::Receiver<anyhow::Result<TaskOutput<Option<SingleDiskFarmId>, String>>>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `-D clippy::type-complexity` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::type_complexity)]`
this `MutexGuard` is held across an `await` point: farmer/src/lib.rs#L567
error: this `MutexGuard` is held across an `await` point --> farmer/src/lib.rs:567:9 | 567 | readers_and_pieces.lock().replace(create_readers_and_pieces(&single_disk_farms).await?); | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling await note: these are all the `await` points this lock is held through --> farmer/src/lib.rs:567:89 | 567 | readers_and_pieces.lock().replace(create_readers_and_pieces(&single_disk_farms).await?); | ^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock = note: `-D clippy::await-holding-lock` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::await_holding_lock)]`
unused import: `FullSelectChain`: node/src/domains/builder.rs#L25
error: unused import: `FullSelectChain` --> node/src/domains/builder.rs:25:51 | 25 | use subspace_service::{FullClient as CFullClient, FullSelectChain}; | ^^^^^^^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_imports)]`
clippy (self-hosted, ubuntu-20.04-x86-64, false)
Clippy had exited with the 101 exit code
clippy (self-hosted, windows-server-2022-x86-64, false)
Process completed with exit code 1.
clippy (self-hosted, windows-server-2022-x86-64, false)
Clippy had exited with the 101 exit code
very complex type used. Consider factoring parts into `type` definitions: farmer/src/lib.rs#L683
error: very complex type used. Consider factoring parts into `type` definitions --> farmer/src/lib.rs:683:9 | 683 | Option<mpsc::Receiver<anyhow::Result<TaskOutput<Option<SingleDiskFarmId>, String>>>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `-D clippy::type-complexity` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::type_complexity)]`
this `MutexGuard` is held across an `await` point: farmer/src/lib.rs#L567
error: this `MutexGuard` is held across an `await` point --> farmer/src/lib.rs:567:9 | 567 | readers_and_pieces.lock().replace(create_readers_and_pieces(&single_disk_farms).await?); | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling await note: these are all the `await` points this lock is held through --> farmer/src/lib.rs:567:89 | 567 | readers_and_pieces.lock().replace(create_readers_and_pieces(&single_disk_farms).await?); | ^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock = note: `-D clippy::await-holding-lock` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::await_holding_lock)]`
clippy (self-hosted, macos-12-arm64, false)
Clippy had exited with the 101 exit code
test (self-hosted, macos-12-arm64, false)
Process completed with exit code 101.
test (self-hosted, windows-server-2022-x86-64, false)
The job was canceled because "self-hosted_macos-12-arm6" failed.
test (self-hosted, windows-server-2022-x86-64, false)
Process completed with exit code 1.
test (self-hosted, windows-server-2022-x86-64, false)
The operation was canceled.
fmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@ae10961054e4aa8b4aa7dffede299aaf087aa33b. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy (self-hosted, ubuntu-20.04-x86-64, false)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@b5b5f21f4797c02da247df37026fcd0a5024aa4d. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy (self-hosted, windows-server-2022-x86-64, false)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@b5b5f21f4797c02da247df37026fcd0a5024aa4d. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy (self-hosted, macos-12-arm64, false)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@b5b5f21f4797c02da247df37026fcd0a5024aa4d. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/