This repository has been archived by the owner on Feb 15, 2024. It is now read-only.
enable timekeeper for dev and test + cargo fmt #911
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
29 errors and 4 warnings
static `GENESIS_CONFIG` is never used:
node/src/domains/evm_chain_spec.rs#L58
error: static `GENESIS_CONFIG` is never used
--> node/src/domains/evm_chain_spec.rs:58:8
|
58 | static GENESIS_CONFIG: OnceCell<Vec<u8>> = OnceCell::new();
| ^^^^^^^^^^^^^^
|
= note: `-D dead-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dead_code)]`
|
unused variable: `relayers`:
node/src/domains/evm_chain_spec.rs#L257
error: unused variable: `relayers`
--> node/src/domains/evm_chain_spec.rs:257:5
|
257 | relayers: Vec<(AccountId, AccountId)>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_relayers`
|
variable does not need to be mutable:
node/src/chain_spec.rs#L358
error: variable does not need to be mutable
--> node/src/chain_spec.rs:358:10
|
358 | let (mut domain_genesis_config, genesis_domain_params) =
| ----^^^^^^^^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `-D unused-mut` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_mut)]`
|
unused variable: `select_chain`:
node/src/domains/domain_instance_starter.rs#L68
error: unused variable: `select_chain`
--> node/src/domains/domain_instance_starter.rs:68:13
|
68 | select_chain,
| ^^^^^^^^^^^^ help: try ignoring the field: `select_chain: _`
|
unused variable: `relayer_id`:
node/src/domains/domain_instance_starter.rs#L60
error: unused variable: `relayer_id`
--> node/src/domains/domain_instance_starter.rs:60:13
|
60 | relayer_id,
| ^^^^^^^^^^ help: try ignoring the field: `relayer_id: _`
|
= note: `-D unused-variables` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_variables)]`
|
very complex type used. Consider factoring parts into `type` definitions:
farmer/src/lib.rs#L683
error: very complex type used. Consider factoring parts into `type` definitions
--> farmer/src/lib.rs:683:9
|
683 | Option<mpsc::Receiver<anyhow::Result<TaskOutput<Option<SingleDiskFarmId>, String>>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `-D clippy::type-complexity` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::type_complexity)]`
|
this `MutexGuard` is held across an `await` point:
farmer/src/lib.rs#L567
error: this `MutexGuard` is held across an `await` point
--> farmer/src/lib.rs:567:9
|
567 | readers_and_pieces.lock().replace(create_readers_and_pieces(&single_disk_farms).await?);
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling await
note: these are all the `await` points this lock is held through
--> farmer/src/lib.rs:567:89
|
567 | readers_and_pieces.lock().replace(create_readers_and_pieces(&single_disk_farms).await?);
| ^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock
= note: `-D clippy::await-holding-lock` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::await_holding_lock)]`
|
use of deprecated type alias `subspace_runtime::GenesisConfig`: GenesisConfig is planned to be removed in December 2023. Use `RuntimeGenesisConfig` instead.:
node/src/chain_spec.rs#L369
error: use of deprecated type alias `subspace_runtime::GenesisConfig`: GenesisConfig is planned to be removed in December 2023. Use `RuntimeGenesisConfig` instead.
--> node/src/chain_spec.rs:369:5
|
369 | GenesisConfig {
| ^^^^^^^^^^^^^
|
use of deprecated type alias `subspace_runtime::GenesisConfig`: GenesisConfig is planned to be removed in December 2023. Use `RuntimeGenesisConfig` instead.:
node/src/chain_spec.rs#L347
error: use of deprecated type alias `subspace_runtime::GenesisConfig`: GenesisConfig is planned to be removed in December 2023. Use `RuntimeGenesisConfig` instead.
--> node/src/chain_spec.rs:347:6
|
347 | ) -> GenesisConfig {
| ^^^^^^^^^^^^^
|
use of deprecated type alias `subspace_runtime::GenesisConfig`: GenesisConfig is planned to be removed in December 2023. Use `RuntimeGenesisConfig` instead.:
node/src/chain_spec.rs#L62
error: use of deprecated type alias `subspace_runtime::GenesisConfig`: GenesisConfig is planned to be removed in December 2023. Use `RuntimeGenesisConfig` instead.
--> node/src/chain_spec.rs:62:44
|
62 | pub type ChainSpec = SerializableChainSpec<GenesisConfig>;
| ^^^^^^^^^^^^^
|
use of deprecated type alias `subspace_runtime::GenesisConfig`: GenesisConfig is planned to be removed in December 2023. Use `RuntimeGenesisConfig` instead.:
node/src/chain_spec.rs#L16
error: use of deprecated type alias `subspace_runtime::GenesisConfig`: GenesisConfig is planned to be removed in December 2023. Use `RuntimeGenesisConfig` instead.
--> node/src/chain_spec.rs:16:54
|
16 | AllowAuthoringBy, BalancesConfig, DomainsConfig, GenesisConfig, MaxDomainBlockSize,
| ^^^^^^^^^^^^^
|
= note: `-D deprecated` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(deprecated)]`
|
unused import: `log`:
node/src/lib.rs#L54
error: unused import: `log`
--> node/src/lib.rs:54:15
|
54 | use tracing::{log, Instrument};
| ^^^
|
unused imports: `DomainId`, `DomainInstanceData`, `RuntimeType`:
node/src/domains/evm_chain_spec.rs#L18
error: unused imports: `DomainId`, `DomainInstanceData`, `RuntimeType`
--> node/src/domains/evm_chain_spec.rs:18:18
|
18 | use sp_domains::{DomainId, DomainInstanceData, OperatorPublicKey, RuntimeType};
| ^^^^^^^^ ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^
|
unused import: `SelfDomainIdConfig`:
node/src/domains/evm_chain_spec.rs#L7
error: unused import: `SelfDomainIdConfig`
--> node/src/domains/evm_chain_spec.rs:7:5
|
7 | SelfDomainIdConfig, SudoConfig, SystemConfig, WASM_BINARY,
| ^^^^^^^^^^^^^^^^^^
|
unused import: `AccountId32ToAccountId20Converter`:
node/src/domains/domain_instance_starter.rs#L27
error: unused import: `AccountId32ToAccountId20Converter`
--> node/src/domains/domain_instance_starter.rs:27:42
|
27 | use crate::domains::utils::{AccountId20, AccountId32ToAccountId20Converter};
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `Convert`:
node/src/domains/domain_instance_starter.rs#L20
error: unused import: `Convert`
--> node/src/domains/domain_instance_starter.rs:20:43
|
20 | use sp_runtime::traits::{Block as BlockT, Convert, NumberFor};
| ^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_imports)]`
|
external crate `sc_proof_of_time` unused in `sdk_node`: remove the dependency or add `use sc_proof_of_time as _;`:
node/src/lib.rs#L1
error: external crate `sc_proof_of_time` unused in `sdk_node`: remove the dependency or add `use sc_proof_of_time as _;`
|
= note: `-D unused-crate-dependencies` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_crate_dependencies)]`
|
clippy (self-hosted, ubuntu-20.04-x86-64, false)
Clippy had exited with the 101 exit code
|
very complex type used. Consider factoring parts into `type` definitions:
farmer/src/lib.rs#L683
error: very complex type used. Consider factoring parts into `type` definitions
--> farmer/src/lib.rs:683:9
|
683 | Option<mpsc::Receiver<anyhow::Result<TaskOutput<Option<SingleDiskFarmId>, String>>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `-D clippy::type-complexity` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::type_complexity)]`
|
this `MutexGuard` is held across an `await` point:
farmer/src/lib.rs#L567
error: this `MutexGuard` is held across an `await` point
--> farmer/src/lib.rs:567:9
|
567 | readers_and_pieces.lock().replace(create_readers_and_pieces(&single_disk_farms).await?);
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling await
note: these are all the `await` points this lock is held through
--> farmer/src/lib.rs:567:89
|
567 | readers_and_pieces.lock().replace(create_readers_and_pieces(&single_disk_farms).await?);
| ^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock
= note: `-D clippy::await-holding-lock` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::await_holding_lock)]`
|
clippy (self-hosted, macos-12-arm64, false)
Clippy had exited with the 101 exit code
|
clippy (self-hosted, windows-server-2022-x86-64, false)
Process completed with exit code 1.
|
clippy (self-hosted, windows-server-2022-x86-64, false)
Clippy had exited with the 101 exit code
|
test (self-hosted, ubuntu-20.04-x86-64, false)
Process completed with exit code 101.
|
test (self-hosted, windows-server-2022-x86-64, false)
The job was canceled because "self-hosted_ubuntu-20_04-" failed.
|
test (self-hosted, windows-server-2022-x86-64, false)
Process completed with exit code 1.
|
test (self-hosted, windows-server-2022-x86-64, false)
The operation was canceled.
|
test (self-hosted, macos-12-arm64, false)
The job was canceled because "self-hosted_ubuntu-20_04-" failed.
|
test (self-hosted, macos-12-arm64, false)
The operation was canceled.
|
fmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@ae10961054e4aa8b4aa7dffede299aaf087aa33b. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
clippy (self-hosted, ubuntu-20.04-x86-64, false)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@b5b5f21f4797c02da247df37026fcd0a5024aa4d. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
clippy (self-hosted, macos-12-arm64, false)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@b5b5f21f4797c02da247df37026fcd0a5024aa4d. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
clippy (self-hosted, windows-server-2022-x86-64, false)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@b5b5f21f4797c02da247df37026fcd0a5024aa4d. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|