-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support snapper 0.11.0 #34
Open
D34DC3N73R
wants to merge
4
commits into
automorphism88:master
Choose a base branch
from
D34DC3N73R:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow matching | as well as │
instead of using `-e 's/^SUBVOLUME[ ]*| //' -e 's/^SUBVOLUME[ ]*│ //'` combine into `-e 's/^SUBVOLUME[ ]*[|│] //'`
oryws
approved these changes
Jul 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Been struggling with this for quite a bit on NixOS when trying to move to 24.05, nice fix
tigattack
approved these changes
Oct 16, 2024
tigattack
added a commit
to monstermuffin/muffins-awesome-nas-stack
that referenced
this pull request
Oct 17, 2024
This is also needed with snapper version 0.12.0 |
niki-on-github
pushed a commit
to niki-on-github/snapraid-btrfs
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapper 0.11.0 uses
│
(light vertical box drawing character) instead of|
(pipe) so sed SUBVOLUME string matching fails, which in turn gives the error message "snapraid-btrfs: No snapper configs found for any data drives in /etc/snapraid.conf". This PR adds the vertical box drawing character to the sed command so either string is removed and snapper configs are matched appropriately. There is also a commit to update the copyright years.using original code with snapper 0.11.0
using PR code with snapper 0.11.0