Major overhaul of charts #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And keep track of a global state
For datepicker
This way switching tabs means queries no longer disappear (as they are hidden by default right now) Not just in the react app. This way when you switch tabs data is
Between SingleChart and the Multi/Functions chart
actualwitch
approved these changes
Jun 8, 2023
| <StyledButton | ||
| onClick={() => { | ||
| navigator.clipboard.writeText(query); | ||
| if (ref.current) { |
There was a problem hiding this comment.
i think you can safely combine the two ifs here? perhaps i'm missing something
|
|
||
| export function FunctionChart(props: Props) { | ||
| const { query, timeRange, setTimeRange, title, description = "" } = props; | ||
| export const FunctionChart = function FunctionChart(props: Props) { |
There was a problem hiding this comment.
Suggested change
| export const FunctionChart = function FunctionChart(props: Props) { | |
| export function FunctionChart(props: Props) { |
src/charts/utils/loadingGraph.ts
Outdated
| import { getNonce } from "../../utils"; | ||
| import { vscode } from "../chart"; | ||
|
|
||
| const requests: Record<string, (result: Result<Timeseries[], String>) => void> = |
There was a problem hiding this comment.
i'm not sure how often items are changed in requests, but it might be beneficial performance-wise to use Map here instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
output.mp4