Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In short, ID-5 raises two issues with regards to CRL validation:
PCCSRouter
currently does not check for the expiration date of the CRL being read.The first issue regarding expiration is being addressed in #23.
This PR focuses on the second issue, by introducing the
authorityKeyIdentifier
andsubjectKeyIdentifier
fields. This allows the quote verifier to check whether a CRL matches with the corresponding CA issuer.The following condition must hold true:
The
authorityKeyIdentifier
of a CRL must equal thesubjectKeyIdentifier
of the Issuer CA.The
subjectKeyIdentifier
is a mandatory field for all CA Certificates.According to the Intel SGX PCK Certificate and CRL Specification doc, the
authorityKeyIdentifier
field is present for all CRLs.