Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOB] DEV-3784: ID-5 #22

Open
wants to merge 6 commits into
base: development
Choose a base branch
from
Open

[TOB] DEV-3784: ID-5 #22

wants to merge 6 commits into from

Conversation

preston4896
Copy link
Collaborator

@preston4896 preston4896 commented Feb 10, 2025

In short, ID-5 raises two issues with regards to CRL validation:

  1. The PCCSRouter currently does not check for the expiration date of the CRL being read.
  2. The CRL stored in the PCCS may not match with the correct Issuer CA Certificate, this is because re-upserting individual CA Certificates does not replace its corresponding CRL. As a result, It is possible for an existing CRL to be incorrectly match with the issuer certificate.

The first issue regarding expiration is being addressed in #23.

This PR focuses on the second issue, by introducing the authorityKeyIdentifier and subjectKeyIdentifier fields. This allows the quote verifier to check whether a CRL matches with the corresponding CA issuer.

The following condition must hold true:
The authorityKeyIdentifier of a CRL must equal the subjectKeyIdentifier of the Issuer CA.

The subjectKeyIdentifier is a mandatory field for all CA Certificates.

According to the Intel SGX PCK Certificate and CRL Specification doc, the authorityKeyIdentifier field is present for all CRLs.

@preston4896
Copy link
Collaborator Author

preston4896 commented Feb 13, 2025

Side note: There is also some changes applied to how X509CRLHelper extracts revokedCertificates from the CRL. This is because revokedCertificates is an optional element of the tbsCertList sequence. If the pointer gets to the location of the 6th element where the ASN.1 tag does not represent a sequence type, this means the CRL does not contain any revoked certificates, and it points to the extension.

@preston4896 preston4896 marked this pull request as ready for review February 13, 2025 06:31
@preston4896 preston4896 changed the title DEV-3784: ID-5 [TOB] DEV-3784: ID-5 Feb 13, 2025
@preston4896 preston4896 changed the base branch from main to development February 14, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant