feat(methods): add SyncMainData and GetFreeSpaceOnDisk #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methods.go
Outdated
|
|
||
| defer resp.Body.Close() | ||
|
|
||
| body, err := io.ReadAll(resp.Body) |
There was a problem hiding this comment.
Not needed, you can fed it directly into the unmarshaller.
There was a problem hiding this comment.
should be done now.
zze0s
reviewed
May 16, 2024
zze0s
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to get the free space left on the default qbittorrent save path.
Not sure if
return 0on L1301 and L1306 is the way to go here?Also check if should make this more generic or should add other things in this call again.Only implemented the bare minimum i needed to make this work.