Add Management API Anomaly endpoints #179
Conversation
| # @see https://auth0.com/docs/api/management/v2#!/Anomaly/get_ips_by_id | ||
| # @param ip [string] The IP to check. | ||
| def check_if_ip_is_blocked(ip) | ||
| raise Auth0::InvalidParameter, 'Must specify an IP' if ip.to_s.empty? |
There was a problem hiding this comment.
What do you think about IP address validation here?
There was a problem hiding this comment.
I think that it is better to return the original response of Auth0 as much as possible.
If the format is incorrect, Auth0 will return:
RESPONSE CODE : 400
RESPONSE BODY
{
"statusCode": 400,
"error": "Bad Request",
"message": "Path validation error: 'Object didn't pass validation for format ipv4: 9919191' on property id (The ip to check).",
"errorCode": "invalid_uri"
}
There was a problem hiding this comment.
The main thing I was thinking here is that we could save an HTTP call if we can catch the error (like we do in other cases). I'll check with the team to see what they think.
| Content-Type: | ||
| - application/json | ||
| Auth0-Client: | ||
| - eyJuYW1lIjoicnVieS1hdXRoMCIsInZlcnNpb24iOiI0LjUuMCJ9 |
There was a problem hiding this comment.
Your attention to detail is commendable!
I'll make a note to anonymize this in our existing cassettes. Nothing secret here but probably best not to have specific application data in here.
There was a problem hiding this comment.
Thank you for your advice!
However, this value has been updated to the same value as the test already included in the master.
Ex:
should_add_a_token_to_the_blacklist.yml:19
You might want to include client id in filter_sensitive_data as well.
spec/spec_helper.rb
config.filter_sensitive_data('CLIENT_SECRET') { ENV['CLIENT_SECRET'] }
config.filter_sensitive_data('API_TOKEN') { ENV['MASTER_JWT'] }
There was a problem hiding this comment.
I think that's probably the best way to deal with it. My main reason for commenting was that I appreciate you updating to the same value as the rest 👍
Co-Authored-By: Josh Cunningham <josh@joshcanhelp.com>
Co-Authored-By: Josh Cunningham <josh@joshcanhelp.com>
Changes
Add endpoint for Anomaly API
References
https://auth0.com/docs/api/management/v2#!/Anomaly/get_ips_by_id
https://auth0.com/docs/api/management/v2#!/Anomaly/delete_ips_by_id
Testing
Checklist