Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Activity from Android library to avoid prompt #533

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

poovamraj
Copy link
Contributor

Changes

We have removed Activities from Auth0.Android library being added to the RNA manifest. This being added caused to open a prompt with asking to choose the sample application twice.

These activities are noted in the manifest to be removed

References

There was an issue noting this here - #531

Testing

We have manually tested this.

We used this command adb shell dumpsys package r which previously showed 2 activities registered to receive the intent. Now there will be just 1 which will avoid the above issue

@poovamraj poovamraj merged commit e78b01a into master Oct 14, 2022
@poovamraj poovamraj deleted the fix-open-with-prompt-android-2.14.0 branch October 14, 2022 17:58
@mailaneel
Copy link

@poovamraj we are still seeing issues with prompt with this change. when checking for registered intents I am seeing on extra com.auth0.react.RedirectActivity registered along with our own one

@AndonMitev
Copy link

AndonMitev commented Dec 12, 2022

I'm having same issue with 2.15.0. I have only this intentfilter:

{
              action: 'VIEW',
              data: [
                {
                  scheme: 'my-custom-scheme',
                },
              ],
              category: ['BROWSABLE', 'DEFAULT'],
            },

running adb shell dumpsys package r output this:

my-custom-scheme:
        975ba9a my-custom-scheme/.MainActivity
        a64e666 my-custom-scheme/com.auth0.react.RedirectActivity

And inside AndroidManifest.xml i have these intent filters:

      <intent-filter>
        <action android:name="android.intent.action.MAIN"/>
        <category android:name="android.intent.category.LAUNCHER"/>
      </intent-filter>
      <intent-filter>
        <action android:name="android.intent.action.VIEW"/>
        <category android:name="android.intent.category.DEFAULT"/>
        <category android:name="android.intent.category.BROWSABLE"/>
        <data android:scheme="scheme1"/>
        <data android:scheme="scheme2"/>
        <data android:scheme="scheme3"/>
      </intent-filter>
      <intent-filter data-generated="true">
        <action android:name="android.intent.action.VIEW"/>
        <data android:scheme="scheme2"/>
        <data android:scheme="scheme3"/>
        <category android:name="android.intent.category.BROWSABLE"/>
        <category android:name="android.intent.category.DEFAULT"/>
      </intent-filter>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants