-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow additional options for authorize and support custom LAPolicy #526
Conversation
Fix issue passing Other configuration options to authorize call
Fix issue passing Other configuration options to authorize call
77e7591
to
3cd18b6
Compare
Hi @chrismcleod thanks a lot for your contribution and this looks like a really neat work. I am discussing with our team about this and will get back to you about this PR soon |
@poovamraj updated to use #542 for the options param I fixed here. |
Hey Guys, Is there any update on this ticket. We are also looking for an additional input to control the LAPolicy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a few comments. @poovamraj please make sure to test this manually.
Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
New usage for custom evaluation policy on iOS:
Testing
What to test
Pass different values for title, description, cancel, fallback. Test FaceID on iOS device. See the different titles are used in the system FaceID UI (they were all title before)
Pass ephemeralSession: true to the 2nd set of options for authorize call. See iOS does not prompt to login with auth0.
Pass LAPolicy.deviceOwnerAuthentication for the new 5th parameter to requireLocalAuthentication. Test that FaceID falls back to device passcode for iOS.
Checklist