Fix android java doc task #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
approved these changes
Jan 26, 2022
This was referenced Jan 27, 2022
Merged
piaskowyk
pushed a commit
to software-mansion/react-native-reanimated
that referenced
this pull request
Apr 1, 2022
…ity with Gradle 7 (#3120) ## Description <!-- Description and motivation for this PR. Inlude Fixes #<number> if this is fixing some issue. Fixes # . --> Fixes #3119. ## Changes Use `implementation` instead of `compile`. This is the same fix as auth0/react-native-auth0#450. <!-- Please describe things you've changed here, make a **high level** overview, if change is simple you can omit this section. For example: - Added `foo` method which add bouncing animation - Updated `about.md` docs - Added caching in CI builds --> <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce Include `react-native-reanimated` with this change in a project using Gradle 7 and it should successfully build. <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please describe both what is changing and why this is important. Include:
androidJavadoc task which isn't used in the project blocked users from integrating the SDK for Gradle 7. We have fixed this by replacing deprecated functionality
References
https://docs.gradle.org/current/userguide/java_plugin.html#tab:configurations
Testing
The SDK has been tested in the latest React Native and Gradle versions as well as the older ones ( RN 0.66.4 & Gradle 6~)
Checklist