-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Implemented MFA APIs #442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! The multifactorChallenge
method has two required parameters that should be optional.
Thanks @Widcket that was a really nice catch. Will fix these and let you know! |
9f337dd
to
0d5694c
Compare
15d3e08
to
b462372
Compare
src/auth/__tests__/index.spec.js
Outdated
const parameters = { | ||
mfaToken: '123', | ||
challengeType: '123', | ||
authenticatorId: '123', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test cases that verify that challengeType
and authenticatorId
are optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to what was done for bindingCode
above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added these changes 👍
b462372
to
d5a7f47
Compare
This is vague, what versions exactly have been tested of each platform? |
Currently I have manually tested the APIs in Android API Level 30 (Android 11). I have also tested the working in iOS with version 15.2. These testings were done with React Native version 66.4. I will test in the base version 65 as well |
Changes
Implemented APIs to use MFA Login with OTP, OOB, Using recovery code and requesting MFA Challenge
New methods added to the public API - loginWithOTP, loginWithOOB, loginWithRecoveryCode, multifactorChallenge
Information on how to use this has been added to the README file as well
References
Testing
I have added required unit tests and did manual testing to all the features as well. I have tested this with Android platform. Since this runs on JS, the iOS platform behaviour should be same. But never the less manual testing will be done for iOS as well
Checklist