-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add passwordless endpoints #270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most are non-blocking, except the doc comments regarding the usage of links in sms.
I think this is good from a UX perspective. |
83c7c83
to
5da2e58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of leftover references that should be addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
This PR adds support for invoking the new passwordless endpoints. It also adds a small note on the readme about them and the grant type that must be enabled first.
There are some UX changes on the second request (the one that performs the authentication). The endpoint expects a
username
parameter, but I'm mapping it from eitheremail
orphoneNumber
. The same happens withotp
, which is getting mapped fromcode
. Please, evaluate if this is desired or if it's only adding noise.References
SDK-1281
Testing
I've tested the email passwordless manually on a sample app. Unit tests are included as well.
Checklist