Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update telemetry format #213

Merged
merged 4 commits into from
Apr 24, 2019
Merged

Update telemetry format #213

merged 4 commits into from
Apr 24, 2019

Conversation

lbalmaceda
Copy link
Contributor

@lbalmaceda lbalmaceda commented Apr 16, 2019 •
edited
Loading

Changes

  • Changed telemetry format: use env to include the library version as the react-native-auth0 key.
  • Updated dev dependencies for fetch-mock to v7. Fixed snapshots.

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@lbalmaceda lbalmaceda added this to the v1-Next milestone Apr 16, 2019
@lbalmaceda lbalmaceda requested a review from joshcanhelp April 16, 2019 13:48
joshcanhelp
joshcanhelp suggested changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing the telemetry as URL parameters. If you tested this against the actual logs to ensure that the telemetry makes it through for all the different endpoints, then we're OK but I've only tested headers.

Is there a reason these are URL parameters and not headers?

management/__tests__/__snapshots__/users.spec.js.snap Outdated
@@ -119,7 +119,7 @@ Object {

exports[`users GET user should send correct payload 1`] = `
Array [
"https://samples.auth0.com/api/v2/users/auth0%7C53b995f8bce68d9fc900099c",
"https://samples.auth0.com/api/v2/users/auth0%7C53b995f8bce68d9fc900099c?auth0Client=eyJuYW1lIjoicmVhY3QtbmF0aXZlLWF1dGgwIiwidmVyc2lvbiI6IjEuMC4wIn0%3D",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a header, not a URL parameter. URL parameters are for redirects.

@lbalmaceda lbalmaceda requested a review from joshcanhelp April 24, 2019 18:56
joshcanhelp
joshcanhelp approved these changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbalmaceda lbalmaceda merged commit e607ff8 into master Apr 24, 2019
@lbalmaceda lbalmaceda modified the milestones: v1.4.1, v1.4.2 Apr 24, 2019
@evansims evansims deleted the update-telemetry branch July 5, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcanhelp joshcanhelp joshcanhelp approved these changes

Assignees
No one assigned
Labels
CH: Changed
Projects
None yet
Milestone
v1.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@lbalmaceda @joshcanhelp