Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Interop Layer #1045

Merged
merged 1 commit into from
Jan 27, 2025
Merged

fix: Interop Layer #1045

merged 1 commit into from
Jan 27, 2025

Conversation

pmathew92
Copy link
Contributor

@pmathew92 pmathew92 commented Jan 27, 2025

Creating seperate PR for #1037 due to issues in Github organizational setup. Credits goes to @guabu for contributing this for us.

Changes

This PR removes the codegenConfig which was caused builds to fail when running under the new architecture. This is also inline with the reactwg recommendation:

If you have already added a Codegen spec to your library, but the library is not fully converted to TurboModules/Fabric, we recommend that you delete it before proceeding. You can add this back when you are ready to convert your library to natively use TurboModules/Fabric without the Interop Layer.

The changes have been tested with a sample app using the following React Native versions:

  • 0.77.0
  • 0.76
  • 0.70.15

A follow-up PR will contain a complete migration to Turbo Modules.

References

#1037

Checklist

@pmathew92 pmathew92 requested a review from a team as a code owner January 27, 2025 09:18
@poovamraj poovamraj changed the title fix: interop_layer fix: Interop Layer Jan 27, 2025
@pmathew92 pmathew92 merged commit d9aa85f into master Jan 27, 2025
4 checks passed
@pmathew92 pmathew92 deleted the interop_layer branch January 27, 2025 09:22
@kailash-b kailash-b mentioned this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants