Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing basePath [SDK-2373] #317

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Fix missing basePath [SDK-2373] #317

merged 1 commit into from
Mar 3, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Mar 2, 2021

Description

This PR prepends the returnTo URL in the client-side withPageAuthRequired with the basePath, if there's one configured. Also the router.push call was replaced with window.location.assign.

References

Fixes #312

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not main

@Widcket Widcket requested a review from a team as a code owner March 2, 2021 21:56
@vercel
Copy link

vercel bot commented Mar 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/auth0/nextjs-auth0/3pyHcEtt6e9jgZU2w3JEheL3VY5r
✅ Preview: Canceled

@Widcket Widcket added CH: Fixed PR is fixing a bug review:small Small review labels Mar 2, 2021
@adamjmcgrath adamjmcgrath merged commit ee518d3 into main Mar 3, 2021
@adamjmcgrath adamjmcgrath deleted the fix/basepath branch March 3, 2021 08:20
@adamjmcgrath adamjmcgrath mentioned this pull request Mar 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
CH: Fixed PR is fixing a bug review:small Small review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

withPageAuthRequired returnTo path with basePath [SDK-2373]
2 participants
@Widcket @adamjmcgrath