Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ship usage #1949

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Enable ship usage #1949

merged 1 commit into from
Mar 10, 2025

Conversation

tusharpandey13
Copy link
Contributor

@tusharpandey13 tusharpandey13 commented Mar 10, 2025

Changes:

  • added shiprc with pnpm usage
  • used version from package.json in auth-client.ts for telemetry.

This should enable ship usage.

@tusharpandey13 tusharpandey13 requested a review from a team as a code owner March 10, 2025 06:22
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.32%. Comparing base (b9944fa) to head (bc71be8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1949      +/-   ##
==========================================
+ Coverage   76.27%   76.32%   +0.05%     
==========================================
  Files          21       21              
  Lines        1513     1512       -1     
  Branches      242      243       +1     
==========================================
  Hits         1154     1154              
+ Misses        352      351       -1     
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tusharpandey13 tusharpandey13 changed the title updated ship config, used version from package.json to use in telemetry data instead of hardcoding Enable ship usage Mar 10, 2025
nandan-bhat
nandan-bhat previously approved these changes Mar 10, 2025
@tusharpandey13 tusharpandey13 merged commit eabf776 into main Mar 10, 2025
12 checks passed
@tusharpandey13 tusharpandey13 deleted the feature/shipconfig branch March 10, 2025 09:33
@tusharpandey13 tusharpandey13 mentioned this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants