Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ID Token to TokenSet #1929

Closed
wants to merge 1 commit into from

Conversation

kenkoooo
Copy link
Contributor

@kenkoooo kenkoooo commented Feb 20, 2025

📋 Changes

In v3, the ID Token was exposed in the session. In v4, although the ID Token claim is stored in SessionData, the actual ID Token is no longer exposed. This pull request reintroduces the ID Token to the session.

📎 References

(None)

🎯 Testing

A unit test has been added to verify that the ID Token provided by the authorization server is correctly stored in the session store.

@kenkoooo kenkoooo requested a review from a team as a code owner February 20, 2025 05:59
@kenkoooo kenkoooo force-pushed the feat/add-id-token-to-token-set branch from eeae918 to e639a87 Compare February 20, 2025 08:57
@jiesia
Copy link

jiesia commented Mar 3, 2025

This is also very useful to me, can you help merge the code?

@kenkoooo
Copy link
Contributor Author

kenkoooo commented Mar 3, 2025

@frederikprijck @tusharpandey13 @nandan-bhat @arpit-jn @gyaneshgouraw-okta @developerkunal
Hi! Would you mind reviewing this PR? Thank you!

@tusharpandey13
Copy link
Contributor

hi @kenkoooo , this PR looks fine.
In order to support id_token field, #1975 is up which will allow session cookie to be > 4KB in size.
I see that your commit is not signed. We require signed commits.
In order to move forward, I will make a new branch in nextjs-auth0 from your commit and sign it using my gpg-key, hence approving this change. In this way, you will retain your contribution history.
Otherwise, you can also sign your commit and do a force push on this branch so that we can merge it directly.

Thanks, we will close this asap.

@tusharpandey13
Copy link
Contributor

Closing this as a duplicate PR has been opened with your contributions in #1978

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants